Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input_size argument from models #1827 #1856

Conversation

Shakib-IO
Copy link
Contributor

πŸ“ Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@blaz-r
Copy link
Contributor

blaz-r commented Mar 15, 2024

Hi, I've checked the changes and they look good, thanks for this.
I'll still need to verify that everything was changed.
Meanwhile, make sure to sign off your commits (click the DCO check that is failing for more details).

Signed-off-by: Shakib-IO <shakib.khan17@northsouth.edu>
@Shakib-IO Shakib-IO force-pushed the remove_input_size_argument_from_models branch from 16d3c4f to b8604ee Compare March 17, 2024 16:02
@Shakib-IO
Copy link
Contributor Author

Thanks @blaz-r

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

@samet-akcay samet-akcay added the Documentation Improvements or additions to documentation label Mar 18, 2024
@samet-akcay samet-akcay added this to the v1.0.1 milestone Mar 18, 2024
@samet-akcay samet-akcay merged commit a8654ff into openvinotoolkit:main Mar 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

πŸ”¨ Remove input_size argument from models
3 participants