Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️ Ensure images are loaded in RGB format #1866

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

davnn
Copy link
Contributor

@davnn davnn commented Mar 16, 2024

📝 Description

Currently, loading grayscale images leads to errors in the visualization callback, because the channels are missing.
This change ensure that images are always loaded as RGB.

Additionally fixes:

✨ Changes

Select what type of change your PR is:

  • [ x ] 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@davnn davnn requested a review from djdameln as a code owner March 16, 2024 12:59
@davnn davnn changed the title Ensure images are loaded in RGB format 🛠️ Ensure images are loaded in RGB format Mar 16, 2024
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR and for your first contribution!

Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davnn, can you update the CHANGELOG.md file as well?

Other than that, it looks good to me, thanks!

@samet-akcay samet-akcay added Enhancement New feature or request Requires Changes Reviewers request changes, which should be addressed by the PR maker labels Mar 18, 2024
@samet-akcay samet-akcay added this to the v1.0.1 milestone Mar 18, 2024
@samet-akcay samet-akcay merged commit 85ce3ac into openvinotoolkit:main Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Requires Changes Reviewers request changes, which should be addressed by the PR maker
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants