Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address minor WinCLIP issues #1889

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

djdameln
Copy link
Contributor

📝 Description

Quick PR that addresses some minor issues with the WinCLIP transforms and readme.

  • use bicubic interpolation in resize, needed to be in line with backbone pre-training transforms
  • Update the instructions for running the model in the readme (passing image size and normalization stats no longer needed since v1).

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@djdameln djdameln requested review from ashwinvaidya17 and removed request for samet-akcay March 21, 2024 16:20
@github-actions github-actions bot added the Docs label Mar 21, 2024
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit a07d47e into openvinotoolkit:main Mar 21, 2024
6 of 7 checks passed
@samet-akcay samet-akcay added this to the v1.0.1 milestone Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants