Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update torch and lightning package versions #1949

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Update torch and lightning package versions #1949

merged 4 commits into from
Apr 5, 2024

Conversation

samet-akcay
Copy link
Contributor

📝 Description

  • This PR bumps the torch and lightning versions.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

dependabot bot and others added 2 commits April 3, 2024 17:12
@dependabot
Update torch requirement from <2.2.0,>=2 to >=2,<2.3.0
09ffb65 
Updates the requirements on [torch](https://github.com/pytorch/pytorch) to permit the latest version.
- [Release notes](https://github.com/pytorch/pytorch/releases)
- [Changelog](https://github.com/pytorch/pytorch/blob/main/RELEASE.md)
- [Commits](pytorch/pytorch@v2.0.0...v2.2.2)

---
updated-dependencies:
- dependency-name: torch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@samet-akcay
Update model.eval based on the new lightning
93dcf46 
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
@samet-akcay samet-akcay requested review from djdameln and ashwinvaidya17 and removed request for ashwinvaidya17 April 4, 2024 13:35
@samet-akcay
Call eval within CFlow torch model
41188bb 
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
@samet-akcay
Call eval within csflow
10a3532 
Signed-off-by: Samet Akcay <samet.akcay@intel.com>
ashwinvaidya17
ashwinvaidya17 approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with the changes. My main question is why are all the eval statements removed?

@ashwinvaidya17
Copy link
Collaborator

I am fine with the changes. My main question is why are all the eval statements removed?

An never mind! They just moved location

@samet-akcay samet-akcay merged commit 56fdacb into openvinotoolkit:main Apr 5, 2024
7 checks passed
@samet-akcay samet-akcay deleted the update-package-versions branch April 5, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@djdameln djdameln Awaiting requested review from djdameln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samet-akcay @ashwinvaidya17