Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Fix EfficientAD's pretrained weigths load path #1966

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

seyeon923
Copy link
Contributor

📝 Description

  • Downloaded and extracted EfficientAD's pretrained models' filenames are "pretrained_teacher_small.pth" or "pretrained_teacher_medium.pth"
  • But, loaded pretrained models' filenames are "pretrained_teacher_EfficientAdModelSize.S.pth" or "pretrained_teacher_EfficientAdModelSize.M.pth", because of getting load path with string interpolation with model size enum itself.
  • Fix load path interpolation to use associated enum value("small" or "medium")
  • 🛠️ Fixes [Bug]: Using invalid pretrained weigths file path from EfficientAD #1965

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@samet-akcay samet-akcay changed the title Minor fix EfficientAD's pretrained weigths load path 🐞 Fix EfficientAD's pretrained weigths load path Apr 9, 2024
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@samet-akcay samet-akcay merged commit 25fc952 into openvinotoolkit:main Apr 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Using invalid pretrained weigths file path from EfficientAD
2 participants