Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕Add warnings ⚠️ for inproper task setting in config files. #274

Merged

Conversation

samet-akcay
Copy link
Contributor

Description

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

@samet-akcay samet-akcay added Enhancement New feature or request Callbacks Data labels Apr 25, 2022
@samet-akcay samet-akcay self-assigned this Apr 25, 2022
@samet-akcay samet-akcay changed the title Add warnings for inproper task setting ➕Add warnings ⚠️ for inproper task setting Apr 25, 2022
@samet-akcay samet-akcay changed the title ➕Add warnings ⚠️ for inproper task setting ➕Add warnings ⚠️ for inproper task setting in config files. Apr 25, 2022
anomalib/data/folder.py Show resolved Hide resolved
anomalib/data/folder.py Show resolved Hide resolved
anomalib/utils/callbacks/visualizer_callback.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will also address the comment on the issue about classification task producing only binary predictions rather than anomaly masks.

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the task type parameter really is redundant for the folder dataset. Especially now that performance metrics are configurable. The user can now choose between classification and segmentation evaluation in 3 ways: task_type parameter, mask_path parameter and metrics.pixel parameter. In understand why this confuses the users, and I feel we need a better design for this. But let's merge this PR as a quick fix and create a better design separately.

@samet-akcay
Copy link
Contributor Author

I agree it's not so intuitive. We need to make it simpler.

@samet-akcay samet-akcay merged commit abd64ed into development Apr 25, 2022
@samet-akcay samet-akcay deleted the fix/sa/add-warnings-for-inproper-task-setting branch April 25, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test anomalib with unsupervised dataset
3 participants