-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate PreProcessor #795
Merged
Merged
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
81cc056
deprecate PreProcessor
djdameln afc0fa5
update configs
djdameln 8cfd746
update deprecation messages
djdameln 149b28e
update video dataset
djdameln 10ce291
update inference dataset
djdameln 1fc5066
move transforms to data module
djdameln 6baba2c
update and extend transform tests
djdameln fcaf75b
fix cyclic import
djdameln ac68040
add validity checks for image size and center crop
djdameln 76865e1
pass image size as tuple
djdameln 70d239b
update path to get_transforms
djdameln a3de5e2
update error message
djdameln 40147a2
fix center crop tuple conversion
djdameln 9f69f54
update inferencers
djdameln 32ba1c1
remove draem transform config
djdameln 2c89ac5
Merge branch 'feature/datamodules' into da/transforms
djdameln 1819bad
update changelog
djdameln 2a7e92a
fix cyclic import
djdameln 5f3e7c4
add crop size vs image size check
djdameln 66642cc
improve readability
djdameln a5a7183
mypy
djdameln cf84bc7
use enum to configure input normalization
djdameln 41559ac
update lightning inference
djdameln 22dad99
Merge branch 'feature/datamodules' into da/transforms
djdameln 748fb7d
update inference dataset
djdameln File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
picky comment: could you define
InputNormalizationType = Union[InputNormalizationMethod, str]
somewhere?to be consistent with
in #748
i'm actually wondering if this is necessary since
InputNormalizationMethod
inherits fromstr
andEnum
, but in any case it would be nice to avoid repetitiveUnion[...]
for maintenance purposesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good point, actually. This works fine:
I guess the only question is if we want to allow users to instantiate the class with a string instead of the enum. So, do we want to allow something like this:
If we do, then we need the Union typing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there it makes handling things harder somehow, I'd say yes :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case we need to keep the
str
typing. For now we'll merge it as, so with the Union typing. We could consider switching to custom types later if needed.