Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove torchvision and torchtext #903

Merged

Conversation

samet-akcay
Copy link
Contributor

Description

  • Remove torchvision and torchtext from the base requirements.

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@github-actions github-actions bot added the Dependencies Pull requests that update a dependency file label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Patch coverage: 94.73% and no project coverage change

Comparison is base (1407cfc) 86.77% compared to head (51a7a82) 86.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #903   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files         165      165           
  Lines        6319     6322    +3     
=======================================
+ Hits         5483     5486    +3     
  Misses        836      836           
Impacted Files Coverage Δ
...ib/models/components/feature_extractors/torchfx.py 92.98% <94.73%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this safe? How do we know the correct version is installed?

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is torchtext automatically installed? If I remember correctly, SC docker files contain additional torchtext dependency in the base image. But that maybe just for fixing the version.

@samet-akcay
Copy link
Contributor Author

nstalled? If I remember correctly, SC docker files contain additi

We don't have a check for torch, but do have for these. Actually this would be even more problematic

@ashwinvaidya17
Copy link
Collaborator

nstalled? If I remember correctly, SC docker files contain additi

We don't have a check for torch, but do have for these. Actually this would be even more problematic

Alright. Let's roll with this then

@samet-akcay
Copy link
Contributor Author

@ashwinvaidya17, I also feel that we should also have anomalib install option that comes with the CLI. I think that would be the safest bet

@djdameln djdameln self-requested a review March 3, 2023 11:24
@samet-akcay samet-akcay merged commit d0b8ce8 into openvinotoolkit:main Mar 3, 2023
@samet-akcay samet-akcay deleted the version/sa/remove-torchvision branch March 3, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants