Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff as the main linter #936

Merged
merged 5 commits into from
Mar 1, 2023

Conversation

samet-akcay
Copy link
Contributor

Description

  • Add ruff as the main linter
  • Remove isort, flake8, pylint and pydocstyle
  • Update the pre-commit versions.
  • Remove redundant packages from requirements/dev.txt

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (98a759e) 86.77% compared to head (ff3e628) 86.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files         165      165           
  Lines        6319     6319           
=======================================
  Hits         5483     5483           
  Misses        836      836           
Impacted Files Coverage Δ
anomalib/data/utils/augmenter.py 98.48% <ø> (ø)
anomalib/deploy/inferencers/torch_inferencer.py 87.23% <ø> (ø)
anomalib/models/csflow/torch_model.py 91.86% <ø> (ø)
anomalib/models/ganomaly/lightning_model.py 100.00% <ø> (ø)
anomalib/models/rkde/region_extractor.py 85.41% <ø> (ø)
anomalib/pre_processing/tiler.py 100.00% <ø> (ø)
anomalib/utils/metrics/aupro.py 87.50% <ø> (ø)
anomalib/models/fastflow/loss.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Hopefully this works for windows users as well.

Copy link
Contributor

@djdameln djdameln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay samet-akcay merged commit 1407cfc into openvinotoolkit:main Mar 1, 2023
@samet-akcay samet-akcay deleted the maintenance/add-ruff branch October 7, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Dependencies Pull requests that update a dependency file Inference Metrics Metric Component. Pre-Processing Setup Tests Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants