accessing /<poolname>/<dataset>/.zfs/shares/.zfs triggers BUG #947
Comments
|
This maybe the same issue as #626. |
|
it should be easy to figure out of smbd actually tries to access .zfs/shares/.zfs in those cases, to confirm that that issue has the same underlying cause. |
|
Yes, this is likely the same issue. However, up until now we never had a trivial reproducer like this. I'm optimistic that with the above test case we'll be able to run this to ground. This issue has been lingering for too long already! |
|
very nice...fix this one...and then see if the other one dissapears as magic as well :) |
|
This happens every time I want to use tab completion before entering inside a snapshot root@mailhost:/mnt/zfs/fulldisk/.zfs/snapshot# ls root@mailhost:/mnt/zfs/fulldisk/.zfs/snapshot# ls mb < TAB key pressed here produces this dmesg [11808.729392] VERIFY(!RW_LOCK_HELD(&l->l_rwlock)) failed I have uploaded the referenced log to: http://dl.transfer.ro/transfer_ro-15sep-8230e5a2db7f.zip root@mailhost:~# ps ax|grep D root@mailhost:~# strace -fp 339 root@mailhost:~# cat /proc/339/status root@mailhost:~# cat /proc/339/syscall root@mailhost:~# cat /proc/339/limits echo t > /proc/sysrq-trigger: Sep 15 14:51:18 mailhost kernel: [11808.729392] VERIFY(!RW_LOCK_HELD(&l->l_rwlock)) failed |
|
ii libzfs1 0.6.0.78-0ubuntu1~precise1 Native ZFS filesystem library for Linux ii spl 0.6.0.78-0ubuntu1 |
|
@mailinglists35 i tried this out, but the snapshots directory doesnt give me this problem. i did however discover that acessing ANY non-existing file in /[poolname]/[dataset]/.zfs/shares/ triggers the bug i reported. |
|
sorry, i'm wrong..... EDIT: It turns out that I'm actually right... Just forgot to rebuild initramfs before I test the fix. |
Otherwise it will cause zpl_shares_lookup() to return a invalid pointer when an error occurs. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com> Closes openzfs#626 openzfs#885 openzfs#947 openzfs#977
Otherwise it will cause zpl_shares_lookup() to return a invalid pointer when an error occurs. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com> Closes openzfs#626 openzfs#885 openzfs#947 openzfs#977
…object_agent/anstyle-parse-0.2.1 Bump anstyle-parse from 0.2.0 to 0.2.1 in /cmd/zfs_object_agent
UPDATE: it seems that accessing ANY non existing file in the shares directory triggers this bug.
Trying to access a .zfs directory under shares triggers some kind of bug:
root@psybak:~# ls /backups/tracy/.zfs/shares/.zfs
Killed
(This directory should not exist at all, but i was just fiddling around.)
Dmesg:
[81441.475366] BUG: unable to handle kernel NULL pointer dereference at 000000000000005f
[81441.475375] IP: [] follow_managed+0x35/0x140
[81441.475384] PGD 121689067 PUD 12c559067 PMD 0
[81441.475390] Oops: 0000 [#1] SMP
[81441.475395] CPU 3
[81441.475397] Modules linked in: zfs(P) zcommon(P) znvpair(P) zavl(P) zunicode(P) spl(O) vmnet(O) vsock(O) vmci(O) vmmon(O) ip6table_filter ip6_tables ebtable_nat ebtables ipt_MASQUERADE iptable_nat nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 xt_state nf_conntrack ipt_REJECT xt_CHECKSUM iptable_mangle xt_tcpudp iptable_filter ip_tables x_tables bridge stp kvm_intel kvm rfcomm bnep bluetooth binfmt_misc dm_crypt nvidia(P) snd_hda_codec_realtek snd_hda_intel snd_hda_codec snd_hwdep snd_pcm ppdev snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq serio_raw snd_timer snd_seq_device snd soundcore snd_page_alloc parport_pc mac_hid xfs lp parport raid10 raid456 async_pq async_xor xor async_memcpy async_raid6_recov raid6_pq async_tx raid1 raid0 multipath linear btrfs zlib_deflate libcrc32c vesafb pata_jmicron r8169 usbhid hid [last unloaded: ipmi_msghandler]
[81441.475475]
[81441.475479] Pid: 22577, comm: ls Tainted: P O 3.2.0-30-generic #48-Ubuntu Gigabyte Technology Co., Ltd. EP35-DS3L/EP35-DS3L
[81441.475486] RIP: 0010:[] [] follow_managed+0x35/0x140
[81441.475491] RSP: 0018:ffff880102277c08 EFLAGS: 00010246
[81441.475494] RAX: 000000000000005f RBX: ffff880102277d18 RCX: ffff880062790300
[81441.475498] RDX: 0000000000000000 RSI: 0000000000000001 RDI: 000000000000005f
[81441.475501] RBP: ffff880102277c58 R08: ffffffff8118d3cb R09: 0000000000000000
[81441.475504] R10: 0000000000000000 R11: 0000000000000004 R12: ffff880062790300
[81441.475507] R13: 0000000000000001 R14: 0000000000000001 R15: 0000000000000000
[81441.475510] FS: 00007f2f47b9f7c0(0000) GS:ffff88019fd80000(0000) knlGS:0000000000000000
[81441.475514] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[81441.475517] CR2: 000000000000005f CR3: 000000017f3e3000 CR4: 00000000000006e0
[81441.475520] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[81441.475523] DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
[81441.475527] Process ls (pid: 22577, threadinfo ffff880102276000, task ffff880110228000)
[81441.475530] Stack:
[81441.475532] 0000000000000001 ffff880102277d40 ffff880102277c58 00ffffff81182b40
[81441.475538] ffff880102277c58 ffff880102277dc8 ffff880102277d18 000000000000005f
[81441.475545] 0000000000000001 ffff880102277d40 ffff880102277cd8 ffffffff81184bed
[81441.475551] Call Trace:
[81441.475556] [] do_lookup+0x14d/0x310
[81441.475561] [] path_lookupat+0x11c/0x750
[81441.475567] [] ? lru_cache_add_lru+0x2d/0x50
[81441.475571] [] do_path_lookup+0x31/0xc0
[81441.475576] [] user_path_at_empty+0x59/0xa0
[81441.475582] [] ? do_page_fault+0x210/0x520
[81441.475586] [] user_path_at+0x11/0x20
[81441.475591] [] vfs_fstatat+0x3a/0x70
[81441.475595] [] vfs_stat+0x1b/0x20
[81441.475600] [] sys_newstat+0x1a/0x40
[81441.475604] [] ? page_fault+0x25/0x30
[81441.475609] [] system_call_fastpath+0x16/0x1b
[81441.475611] Code: 5d d8 4c 89 65 e0 4c 89 6d e8 4c 89 75 f0 4c 89 7d f8 66 66 66 66 90 4c 8b 27 45 31 ff 48 89 fb 41 89 f5 c6 45 cf 00 48 8b 7b 08 <8b> 07 41 89 c6 41 81 e6 00 00 07 00 75 47 80 7d cf 00 74 05 4c
[81441.475661] RIP [] follow_managed+0x35/0x140
[81441.475666] RSP
[81441.475668] CR2: 000000000000005f
[81441.475671] ---[ end trace ed8d683991ae1ad6 ]---
kernel:
Linux psybak 3.2.0-30-generic #48-Ubuntu SMP Fri Aug 24 16:52:48 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux
zfsutils 0.6.0.71
zfs-dkms 0.6.0.71
The text was updated successfully, but these errors were encountered: