Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Remove znode's z_uid/z_gid member #4685

Closed
wants to merge 2 commits into from
Closed

[RFC] Remove znode's z_uid/z_gid member #4685

wants to merge 2 commits into from

Commits on Jul 25, 2016

  1. Check whether the kernel supports i_uid/gid_read/write helpers 

    Since the concept of a kuid and the need to translate from it to
ordinary integer type was added in kernel version 3.5 implement necessary
plumbing to be able to detect this condition during compile time. If
the kernel doesn't support the kuid then just fall back to directly
accessing the respective struct inode's members
    Nikolay Borisov committed Jul 25, 2016
    Configuration menu
    Copy the full SHA
    5fe322f View commit details
    Browse the repository at this point in the history

  2. Remove znode's z_uid/z_gid member 

    Remove duplicate z_uid/z_gid member which are also held in the
generic vfs inode struct. This is done by first removing the members
from struct znode and then using the KUID_TO_SUID/KGID_TO_SGID
macros to access the respective member from struct inode. In cases
where the uid/gids are being marshalled from/to disk, use the newly
introduced zfs_(uid|gid)_(read|write) functions to properly
save the uids rather than the internal kernel representation.
    Nikolay Borisov committed Jul 25, 2016
    Configuration menu
    Copy the full SHA
    49366b2 View commit details
    Browse the repository at this point in the history