Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rsend_014_pos and send-c_volume test cases #6088

Merged
merged 1 commit into from
May 4, 2017

Conversation

behlendorf
Copy link
Contributor

The following three test cases occasionally fail the automated
testing. For the moment disable these test cases until the
underlying issues can be fully investigated and resolved.

zfs_destroy_010_pos - #5893
rsend_020_pos - #6086 (32-bit only)
send-c_volume - #6087 (32-bit only)

Signed-off-by: Brian Behlendorf behlendorf1@llnl.gov
Issue #5893
Issue #6086
Issue #6087

@@ -35,6 +35,11 @@

verify_runnable "both"

# See issue: https://github.com/zfsonlinux/zfs/issues/6086
if is_32bit; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change in the wrong file? According to your comments, you intended to skip rsend_020_pos.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The patch is right, the commit message is wrong.

@behlendorf
Copy link
Contributor Author

Closing. This may not be needed, after all. After updated the 32-bit AMI the failures for the moment are no longer reproducible.

@behlendorf behlendorf closed this May 2, 2017
@dinatale2
Copy link
Contributor

dinatale2 commented May 3, 2017

Looks like send-c_volume is the only test that's still causing trouble on the 32-bit builder. Would you mind refreshing this patch to just disable that one?

Also, rsend_019_pos is labelled in this PR as 32-bit only, but issue #6086 indicates that it may be a problem on x86_64 as well. I'm not noticing many failures from that one on our x86_64 builders though. So not sure if we should disable it for safety. I think we can always disable it later if it crops up again. It's not failing on the 32-bit builder (at least for now) since it was updated.

@dinatale2 dinatale2 reopened this May 3, 2017
@behlendorf behlendorf force-pushed the disable-tests branch 2 times, most recently from a4f0bb9 to da34f7c Compare May 4, 2017 01:30
@behlendorf
Copy link
Contributor Author

Updated. The two remaining test cases I've only disabled on the 32-bit test systems since we don't commonly see any failures on x86_64 from the bots.

@behlendorf behlendorf changed the title Disable 3 test cases Disable rsend_019_pos and send-c_volume test cases (32-bit) May 4, 2017
The send-c_volume test case has been observed to occasionally
fail on 32-bit systems.  Until this issue is fully understood
disable this test case.

The rsend_014_pos test case can occasionally fail due to an
EBUSY during export.  This can lead to subsequent test failures.
Resolve the issue by retrying the export on EBUSY.  Additionally,
remove the gratuitious use of eval.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf
Copy link
Contributor Author

behlendorf commented May 4, 2017

I've removed chunk which disables rsend_019_pos from this test case and instead resolved an issue in the previous test case rsend_014_pos observed here. I'd like to hold off on disabling rsend_019_pos for now until we see more of it in the automated testing.

@behlendorf behlendorf changed the title Disable rsend_019_pos and send-c_volume test cases (32-bit) Update rsend_014_pos and send-c_volume test cases May 4, 2017
@behlendorf behlendorf merged commit 4cb932d into openzfs:master May 4, 2017
@behlendorf behlendorf deleted the disable-tests branch April 19, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants