Adds zipkin.internal.Span2Converter #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2017
|
followed by #1671 |
codefromthecrypt
force-pushed
the
span2-converter
branch
from
f1066de
to
f9fcf15
Compare
This adds an internal copy of a span conversion utility mentioned in issue #1499. This is starting internal to ease review and allow incremental progress. The first consumer will be dependency linking.
codefromthecrypt
force-pushed
the
span2-converter
branch
from
f9fcf15
to
4aeeaec
Compare
codefromthecrypt
pushed a commit
that referenced
this pull request
Jul 28, 2017
* Adds zipkin.internal.Span2Converter (#1670) This adds an internal copy of a span conversion utility mentioned in issue #1499. This is starting internal to ease review and allow incremental progress. The first consumer will be dependency linking. * Adds zipkin.internal.Span2Codec.JSON (#1671) This adds an internal copy of a span json codec issue #1499. This starts internal to ease review and allow incremental progress. The first consumer will be Elasticsearch, as this format removes nested queries. Note: this change also introduces json serialization of Span2, which allows future use in Spark. * Drops internal DependencyLinkSpan for Span2 This drops the internal type of DependencyLinkSpan in favor of the Span2 type coming in #1499. Doing so now gives us practice, solves a few bugs along the way. When Span2 becomes non-internal, the change will be a simple package rename.
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
This adds an internal copy of a span conversion utility mentioned in issue openzipkin#1499. This is starting internal to ease review and allow incremental progress. The first consumer will be dependency linking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an internal copy of a span conversion utility mentioned in
issue #1499. This is starting internal to ease review and allow
incremental progress. The first consumer will be dependency linking.
Benchmarks