Decouples v2 types from v1 types, in preparation of a new package #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
This moves all the code needed for v2 types into zipkin.internal.v2 without any references to code outside the package. To reduce duplication, "v1" code can reference v2 types (as they need to in order to covert for example). Once this is in, we can consider refactoring out a v2 module.
codefromthecrypt
force-pushed
the
finish-v2
branch
from
5a6ea03
to
4a6288a
Compare
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…enzipkin#1726) This moves all the code needed for v2 types into zipkin.internal.v2 without any references to code outside the package. To reduce duplication, "v1" code can reference v2 types (as they need to in order to covert for example). Once this is in, we can consider refactoring out a v2 module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all the code needed for v2 types into zipkin.internal.v2
without any references to code outside the package. To reduce
duplication, "v1" code can reference v2 types (as they need to in order
to covert for example). Once this is in, we can consider refactoring out
a v2 module.