Adds v2 StorageComponent and allows the server to use it directly #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefromthecrypt
force-pushed
the
v2storage-component
branch
from
8f48c03
to
429405b
Compare
codefromthecrypt
changed the title
22 tasks
codefromthecrypt
force-pushed
the
v2storage-component
branch
from
429405b
to
313a5fc
Compare
This adds a type for the v2 StorageComponent so that future storage implementations can be made without a compile dependency on the v1 jar. This is internal until everything is verified.
codefromthecrypt
force-pushed
the
v2storage-component
branch
from
313a5fc
to
0baa31f
Compare
abesto
pushed a commit
to abesto/zipkin
that referenced
this pull request
Sep 10, 2019
…enzipkin#1729) This adds a type for the v2 StorageComponent so that future storage implementations can be made without a compile dependency on the v1 jar. This is internal until everything is verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a type for the v2 StorageComponent so that future storage
implementations can be made without a compile dependency on the v1 jar.
This is internal until everything is verified.