Upgrade to node 17 #274
Merged
Upgrade to node 17 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
end2end tests get stuck. I think it is related to Edit: actually the app is not even opening. |
nicarl
force-pushed
the
upgrade_to_node_17
branch
from
ab555a8
to
d7ed607
Compare
nicarl
commented
Dec 15, 2021
| "typescript": "^4.5.4", | ||
| "wait-on": "^6.0.0" | ||
| }, | ||
| "scripts": { | ||
| "start": "run-script-os", | ||
| "start:darwin:linux": "concurrently \"yarn build:dev; BROWSER=none ESLINT_NO_DEV_ERRORS=true react-scripts start\" \"wait-on http://localhost:3000 && electron .\"", | ||
| "start:win32": "concurrently \"yarn build:dev & cross-env BROWSER=none ESLINT_NO_DEV_ERRORS=true react-scripts start\" \"wait-on http://localhost:3000 && electron .\"", | ||
| "start:darwin:linux": "concurrently \"yarn build:dev; BROWSER=none ESLINT_NO_DEV_ERRORS=true react-scripts start\" \"wait-on http://127.0.0.1:3000 && electron .\"", |
There was a problem hiding this comment.
wait-on http://localhost:3000 stales because of jeffbski/wait-on#109
Fix: #272 Signed-off-by: Nico Carl <nicocarl@protonmail.com>
nicarl
force-pushed
the
upgrade_to_node_17
branch
from
d7ed607
to
6af2ec8
Compare
Closed
FlorianSchepers
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Upgrade to node 17
Context and reason for change
Node 17 is the most current node version
How can the changes be tested
Full CI feedback should be green, tested locally with node 17.2 on linux