Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tested with ARM #31

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Tested with ARM #31

merged 3 commits into from
Jun 3, 2021

Conversation

hyder
Copy link
Contributor

@hyder hyder commented May 26, 2021 •
edited
Loading

  • Tested with ARM
  • Change default shape to E4.Flex
  • Added ability to control operator state

karthicgit-zz
karthicgit-zz reviewed May 31, 2021
View reviewed changes
Copy link
Contributor

@karthicgit-zz karthicgit-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May i know the default shape will be E4 or A1.? In variables A1 is set as default but in doc and terraform.tfvars E4 is set as default.

@hyder
Copy link
Contributor Author

hyder commented Jun 1, 2021

May i know the default shape will be E4 or A1.? In variables A1 is set as default but in doc and terraform.tfvars E4 is set as default.

I think we'll keep to E4 for now

@hyder
Update variables.tf
3f5c83d 
Changed default shape in variables to E4
@hyder hyder linked an issue Jun 3, 2021 that may be closed by this pull request
Add support for ARM Flex shape #30
Closed
@hyder hyder merged commit 32244a8 into oracle-terraform-modules:main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthicgit-zz karthicgit-zz karthicgit-zz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for ARM Flex shape
2 participants
@hyder @karthicgit-zz