Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add assign_dns var to support disabled DNS #77

Merged
merged 2 commits into from
Nov 28, 2022
Merged

feat: Add assign_dns var to support disabled DNS #77

merged 2 commits into from
Nov 28, 2022

Conversation

devoncrouse
Copy link
Contributor

@devoncrouse devoncrouse commented Nov 28, 2022 •
edited
Loading

Proposed changes

  • Subnet DNS label and instance hostname label cannot be defined when disabled on the VCN. This change adds the same assign_dns var used in the terraform-oci-oke module to enable operator creation in this configuration.
  • Policy names must be unique within a compartment. Added a unique suffix to the operator instance principal policy name to prevent conflicts.

@devoncrouse
feat: Add assign_dns var to support disabled DNS
33534e3 
Signed-off-by: Devon Crouse <devon.crouse@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 28, 2022
tariq1890
tariq1890 previously approved these changes Nov 28, 2022
View reviewed changes
@devoncrouse devoncrouse requested review from hyder and removed request for hyder November 28, 2022 18:09
@devoncrouse
fix: Add unique suffix to instance principal policy name
a4fc0af 
Signed-off-by: Devon Crouse <devon.crouse@oracle.com>
hyder
hyder reviewed Nov 28, 2022
View reviewed changes
subnets.tf Show resolved Hide resolved
@hyder hyder merged commit a8a4801 into oracle-terraform-modules:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyder hyder hyder approved these changes

@tariq1890 tariq1890 tariq1890 left review comments

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devoncrouse @hyder @tariq1890