Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .cover to ignore #463

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

TerryHowe
Copy link
Member

No description provided.

Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title Add .cover to ignore chore: add .cover to ignore Mar 17, 2023
@shizhMSFT
Copy link
Contributor

@TerryHowe What is a .cover file? Is that a coverage file?

@TerryHowe
Copy link
Member Author

What is a .cover file? Is that a coverage file?

Yes, but now I don't see a coverage target in the Makefile, just a covhtml target. I had one for some reason.

Signed-off-by: Terry Howe <tlhowe@amazon.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #463 (5a993f3) into main (97a80e5) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #463   +/-   ##
=======================================
  Coverage   72.80%   72.80%           
=======================================
  Files          49       49           
  Lines        4512     4512           
=======================================
  Hits         3285     3285           
  Misses        919      919           
  Partials      308      308           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shizhMSFT shizhMSFT merged commit c1bf59e into oras-project:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants