Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'MemoryStore' #602

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

uanid
Copy link
Contributor

@uanid uanid commented Sep 19, 2023

Features:

  • Add MemoryStore

I submitted a pull request for MemoryStore to oras-credentials-go a week ago. However, the repository has since been deprecated. I've created an identical PR to this one.

Reference Issue: Here

Signed-off-by: Uanid <uanid@outlook.com>
Copy link
Member

@Wwwsylvia Wwwsylvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #602 (7dc9201) into main (577bffe) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #602      +/-   ##
==========================================
+ Coverage   74.58%   74.64%   +0.06%     
==========================================
  Files          58       59       +1     
  Lines        5252     5266      +14     
==========================================
+ Hits         3917     3931      +14     
  Misses        983      983              
  Partials      352      352              
Files Changed Coverage Δ
registry/remote/credentials/memory_store.go 100.00% <100.00%> (ø)

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Wwwsylvia Wwwsylvia merged commit 9f83e67 into oras-project:main Sep 20, 2023
7 checks passed
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants