Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle OnCopySkipped #609

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

Wwwsylvia
Copy link
Member

Fix: #552

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #609 (18e624b) into main (e5cabfa) will decrease coverage by 0.02%.
The diff coverage is 33.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
- Coverage   74.67%   74.65%   -0.02%     
==========================================
  Files          59       59              
  Lines        5271     5275       +4     
==========================================
+ Hits         3936     3938       +2     
- Misses        983      985       +2     
  Partials      352      352              
Files Coverage Δ
copy.go 62.65% <33.33%> (-0.22%) ⬇️

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 2d371a0 into oras-project:main Sep 26, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the fix_skip branch September 26, 2023 10:48
Wwwsylvia added a commit to Wwwsylvia/oras-go that referenced this pull request Oct 19, 2023
Fix: oras-project#552
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Oct 20, 2023
Fix: #552
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia mentioned this pull request Oct 20, 2023
4 tasks
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] onCopySkipped called unexpectly on root node when using oras.Copy
3 participants