Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create an interface for status console #1481

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

TerryHowe
Copy link
Member

What this PR does / why we need it:

Create a interface for console so that alternate implementations can exist. In doing this, I found the Size() method was not properly implemented, so I created a GetHeightWidth() method.

Partial: #1461

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.05%. Comparing base (e0f4066) to head (83474e7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...md/oras/internal/display/status/console/console.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
- Coverage   86.10%   86.05%   -0.06%     
==========================================
  Files         118      118              
  Lines        4224     4223       -1     
==========================================
- Hits         3637     3634       -3     
- Misses        350      351       +1     
- Partials      237      238       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TerryHowe TerryHowe force-pushed the refactor-console branch 3 times, most recently from 4af9db7 to 76ba908 Compare August 22, 2024 13:50
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Terry for contributing. LGTM with minor sugggestions.

Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 952d867 into oras-project:main Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants