feature: build binary for OS and arch by default #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerryHowe
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
qweeah
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
=======================================
Coverage 85.78% 85.78%
=======================================
Files 116 116
Lines 4073 4073
=======================================
Hits 3494 3494
Misses 347 347
Partials 232 232 ☔ View full report in Codecov by Sentry. |
qweeah
requested changes
Sep 5, 2024
qweeah
reviewed
Sep 6, 2024
qweeah
reviewed
Sep 6, 2024
qweeah
reviewed
Sep 9, 2024
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
TerryHowe
force-pushed
the
default-build-os-arch
branch
from
3ee6261
to
15d5364
Compare
qweeah
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Build the binary by default for the current OS and arch.