Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide status output when using --output - #1506

Closed

Conversation

wangxiaoxuan273
Copy link
Contributor

@wangxiaoxuan273 wangxiaoxuan273 commented Sep 20, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1503

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.07%. Comparing base (961e9f8) to head (520fecd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   86.01%   86.07%   +0.06%     
==========================================
  Files         117      117              
  Lines        4226     4231       +5     
==========================================
+ Hits         3635     3642       +7     
+ Misses        353      351       -2     
  Partials      238      238              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is more like a workaround. A more proper way to fix is to adopt the display model defined in https://github.com/oras-project/oras/tree/main/cmd/oras/internal/display.

@TerryHowe
Copy link
Member

Maybe https://github.com/oras-project/oras/blob/main/cmd/oras/internal/display/status/discard.go

@wangxiaoxuan273 wangxiaoxuan273 deleted the output-output branch September 23, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oras manifest index create/update --output - should hide other stdout output
3 participants