test: add unit test for error scenario in internal/credential/store.go
#982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enraiha0307
requested review from
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
shizhMSFT
changed the title
internal/credential/store.go
shizhMSFT
requested changes
Jun 20, 2023
enraiha0307
force-pushed
the
store-file-code-coverage
branch
from
5f33119
to
08cfc6f
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #982 +/- ##
==========================================
+ Coverage 81.09% 81.26% +0.17%
==========================================
Files 57 57
Lines 2904 2904
==========================================
+ Hits 2355 2360 +5
+ Misses 375 371 -4
+ Partials 174 173 -1 |
qweeah
requested changes
Jun 29, 2023
enraiha0307
force-pushed
the
store-file-code-coverage
branch
3 times, most recently
from
735d053
to
70d6840
Compare
shizhMSFT
reviewed
Jun 29, 2023
shizhMSFT
requested changes
Jun 29, 2023
enraiha0307
force-pushed
the
store-file-code-coverage
branch
from
70d6840
to
9136a50
Compare
shizhMSFT
reviewed
Jun 30, 2023
enraiha0307
force-pushed
the
store-file-code-coverage
branch
from
9136a50
to
57011ec
Compare
shizhMSFT
reviewed
Jul 7, 2023
TerryHowe
reviewed
Jul 7, 2023
enraiha0307
force-pushed
the
store-file-code-coverage
branch
from
57011ec
to
ea6e802
Compare
enraiha0307
force-pushed
the
store-file-code-coverage
branch
from
ea6e802
to
7d8ce2c
Compare
qweeah
force-pushed
the
store-file-code-coverage
branch
from
7d8ce2c
to
88ae475
Compare
Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com>
Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com>
qweeah
force-pushed
the
store-file-code-coverage
branch
from
88ae475
to
70bac9c
Compare
qweeah
pushed a commit
to qweeah/oras
that referenced
this pull request
Jul 21, 2023
…go` (oras-project#982) Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
pushed a commit
to qweeah/oras
that referenced
this pull request
Jul 21, 2023
…go` (oras-project#982) Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
pushed a commit
to shizhMSFT/oras
that referenced
this pull request
Aug 3, 2023
…go` (oras-project#982) Signed-off-by: Akanksha Gahalot <akankshagahlot0307@gmail.com>
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a unit test file for
internal/credential/store.goto increase its code coverage from 78.57% to 100%.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
This PR is a small part of #972
Please check the following list: