Guard against invalid percentiles (#380)

ordinals · Aug 30, 2022 · 29a08d4 · 29a08d4
1 parent 344031c
commit 29a08d4
Showing 1 changed file with 17 additions and 3 deletions.
diff --git a/src/ordinal.rs b/src/ordinal.rs
@@ -158,11 +158,19 @@ impl Ordinal {
 
     let percentile = percentile[..percentile.len() - 1].parse::<f64>()?;
 
-    let position = percentile / 100.0;
+    if percentile < 0.0 {
+      bail!("Invalid percentile: {}", percentile);
+    }
+
+    let last = Ordinal::LAST.n() as f64;
 
-    let n = position * Ordinal::LAST.n() as f64;
+    let n = (percentile / 100.0 * last).round() as u64;
 
-    Ok(Ordinal(n.round() as u64))
+    if n > Ordinal::LAST.n() {
+      bail!("Invalid percentile: {}", percentile);
+    }
+
+    Ok(Ordinal(n as u64))
   }
 }
 
@@ -520,6 +528,12 @@ mod tests {
     assert_eq!(Ordinal::LAST.percentile(), "100%");
   }
 
+  #[test]
+  fn from_percentile() {
+    "-1%".parse::<Ordinal>().unwrap_err();
+    "101%".parse::<Ordinal>().unwrap_err();
+  }
+
   #[test]
   fn percentile_round_trip() {
     fn case(n: u64) {