add balance command

[rot13maxi]

Add a simple balance command. Here's what it looks like:

$ ./target/debug/ord --signet wallet balance
0.0099852 BTC

closes #1036

[casey]

Nice! Don't worry about rebasing. I'll just squash at the end.

I'm leaning towards displaying the balance in sats:

• BTC are enormous, so probably too large to be useful, and people aren't good at reading long decimals.
• The rest of the commands are sat oriented.
• If we accept BTC amounts as input, I'd rather avoid floating point numbers.
• Everything is pretty sat-oriented.

What do you think?

This could use an integration test in tests/wallets.rs. It should run ord wallet balance, get a zero balance, mine some coins to the wallet, and then run the command again and see a nonzero balance. I'm not sure if we'll need to implement a new test RPC server command, but we can cross that bridge when we get to it.

[rot13maxi]

ended up doing a rebase anyway.
Now displays balance in sats, and there's an integration test. Let me know if there's anything else you want to see in here

[casey]

Looking good, a few minor comments.

[casey]

vv minor changes

[casey]

You can just do:

Suggested change

	let _ = &rpc_server.mine_blocks(1);
	rpc_server.mine_blocks(1);

let _ = is only needed when ignoring a type that has #[must_use] on it, like Result.

[rot13maxi]

right you are

[casey]

Since this doesn't have any interpolations, format is unnecessary:

Suggested change

	.expected_stdout(format!("5000000000\n"))
	.expected_stdout("5000000000\n")

There's a just recipe for running some of the checks that run on ci, try just ci, or look for the ci recipe in the justfile to find the commands to run. CI runs clippy (which would complain about this), checks formatting, and runs bin/forbid, which forbids certain strings from appearing in the codebase.

bin/forbid is actually quite useful. It forbids the string todo, so if you want to make sure you don't forget something before comitting, write todo: I need to do blah blah blah and CI will complain, so you don't need to worry about forgetting it.

[rot13maxi]

ah! I haven't used just before. I'll check that out so you don't have to keep commenting on things that the linter would check. thanks!

[casey]

No worries! just is kind of like make, but only for saving and running commands, and less weird.

[rot13maxi]

yeah, this is great. should be a lot easier to make sure im conforming to style, etc. for future PRs :)

[casey]

LGTM!