Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add white background to inscription content #1054

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Add white background to inscription content #1054

merged 4 commits into from
Dec 23, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 22, 2022 •
edited
Loading

Without 101% width and height I was getting a weird issue where SVG inscriptions on the main page would display with a white border on one side.

Before

Screen Shot 2022-12-22 at 1 20 26 PM

Screen Shot 2022-12-22 at 1 20 31 PM

After

Screen Shot 2022-12-22 at 1 20 17 PM

Screen Shot 2022-12-22 at 1 20 40 PM

@casey casey requested a review from raphjaph December 22, 2022 21:19
@casey casey mentioned this pull request Dec 22, 2022
Closed
@casey casey merged commit 6b52915 into master Dec 23, 2022
@casey casey deleted the white-background branch December 23, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@casey @raphjaph