Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set lower max age for not found #2240

Merged
merged 4 commits into from
Jul 2, 2023
Merged

Set lower max age for not found #2240

merged 4 commits into from
Jul 2, 2023

Conversation

revofusion
Copy link
Contributor

Lower cache time to 600 (10 minutes) when an inscription is not found

Resolve issue #2232

veryordinally
veryordinally approved these changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@veryordinally veryordinally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raphjaph this looks good to me

@revofusion
Copy link
Contributor Author

revofusion commented Jul 2, 2023 •
edited
Loading

@veryordinally I have made a slight change to not set immutable on not found. Lint issue fixed as well.

@raphjaph
Copy link
Collaborator

raphjaph commented Jul 2, 2023 •
edited
Loading

Thanks, this is a very good catch!

For the future if you want to run our CI stuff have a look at the justfile recipe called ci. We check linting, formatting and common mistakes.

@raphjaph raphjaph enabled auto-merge (squash) July 2, 2023 09:18
@raphjaph raphjaph merged commit 11913c4 into ordinals:master Jul 2, 2023
6 checks passed
@raphjaph raphjaph mentioned this pull request Jul 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veryordinally veryordinally veryordinally approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@revofusion @raphjaph @veryordinally