Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid caching error responses #2637

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

lifofifoX
Copy link
Collaborator

Error responses are currently cached by cloudflare, which is an attack vector. Someone could just watch mempool and make /content requests before the tx confirmation.

@raphjaph I am not able to get the tests to pass. Can you please point me in the right direction re: how to do this?

@raphjaph
Copy link
Collaborator

raphjaph commented Nov 7, 2023

@devord you set the header in the wrong place, this was a quick fix so we just did it for you :)

@casey casey enabled auto-merge (squash) November 7, 2023 21:41
@casey casey merged commit 37ba32b into ordinals:master Nov 7, 2023
6 checks passed
@lifofifoX
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants