Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rune balances #2782

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Rune balances #2782

merged 2 commits into from
Dec 1, 2023

Conversation

casey
Copy link
Collaborator

@casey casey commented Nov 30, 2023

This is ready for review!

I'm not sure what the right output format should be. Should it be grouped by rune or grouped by output?

Grouped by output:

{
  "outpoint": {
    "rune": "balance",
    "rune": "balance",
  },
  "outpoint": {
    "rune": "balance",
    "rune": "balance",
  }
}

Grouped by rune:

{
  "rune": {
    "outpoint": "balance",
    "outpoint": "balance",
  },
  "rune": {
    "outpoint": "balance",
    "outpoint": "balance",
  }
}

Our not grouped at all:

{
  ["outpoint", "rune", "balance"],
  ["outpoint", "rune", "balance"],
  ["outpoint", "rune", "balance"]
}

@casey casey marked this pull request as ready for review December 1, 2023 08:01
@casey casey requested a review from raphjaph December 1, 2023 08:06
@casey casey merged commit 733b74d into ordinals:master Dec 1, 2023
6 checks passed
@casey casey deleted the rune-balances branch December 1, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants