feat(redb): add repair progress #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikicat
force-pushed
the
feat/repair-progress
branch
from
414b359
to
cdb0d64
Compare
|
Does this need to be in a background thread? Can we update the progress bar directly in the callback? |
We can't because progress callback should be an |
|
In that case, try wrapping the progress bar in a Mutex. |
nikicat
force-pushed
the
feat/repair-progress
branch
2 times, most recently
from
60c2854
to
ff205b9
Compare
casey
force-pushed
the
feat/repair-progress
branch
from
46240e5
to
8b35355
Compare
|
Nice, merged! |
torkelrogstad
pushed a commit
to torkelrogstad/ord
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds progress bar for database repair. It doesn't work smoothly though: due to redb limitation, only 30%, 60% and 90% steps exist.