migrating outgoing.rs to snafu error handling #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoni9n
changed the title
…om/cryptoni9n/ord into convert-outgoing.rs-to-snafu-error
casey
requested changes
Aug 15, 2024
src/error.rs
Outdated
| @@ -45,6 +46,39 @@ pub enum SnafuError { | |||
| }, | |||
| #[snafu(display("Unrecognized representation `{}`", input))] | |||
| UnrecognizedRepresentation { source: error::Error, input: String }, | |||
| #[snafu(display("Unrecognized outgoing amount: `{}`", input))] | |||
| UnrecognizedAmount { | |||
There was a problem hiding this comment.
I think I would call these *Parse instead of Unrecognized*.
There was a problem hiding this comment.
Thanks Casey - I'm pushing changes now that rename all of the Unrecognized* errors, except for UnrecognizedRepresentation, because that was already merged as part of #3192.
src/error.rs
Outdated
| #[snafu(display("Unrecognized outgoing: `{}`", input))] | ||
| UnrecognizedOutgoing { input: String }, | ||
| #[snafu(display("Failed to parse decimal: {}", source))] | ||
| DecimalParse { source: error::Error, input: String }, |
There was a problem hiding this comment.
If this is only used in parsing rune amounts, then maybe RuneAmountParse.
There was a problem hiding this comment.
sure thing, pushing changes now. Are you ok with having the following errors be so similar, or would you prefer to merge them?
OutgoingRuneParse and RuneParse
OutgoingSatParse and SatParse
OutgoingInscriptionIdParse and InscriptionIdParse
There was a problem hiding this comment.
Whoops, sorry, I wasn't looking at those other errors. Those errors can all be combined. In general, existing errors should be reused.
There was a problem hiding this comment.
ok, updates pushed.
…om/cryptoni9n/ord into convert-outgoing.rs-to-snafu-error
casey
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
LGTM! I made a couple of small changes before merging.
- If a name conflicts, I usually don't import and rename it, I just refer to it by its full name, so I removed the
use bitcoin::address::Error as AddressErrorand just referred to it asbitcoin::address::Error. - I made
Representation::from_strreturn a SnafuError, which avoids needing to wrap an anyhow error in a snafu error.
danadi7
pushed a commit
to sadoprotocol/ord
that referenced
this pull request
Sep 20, 2024
* Change test-bitcoincore-rpc to mockcore in README.md (ordinals#3842) * Commit twice to work around redb off-by-one bug (ordinals#3856) * Release 0.19.1 (ordinals#3864) - Bump version: 0.19.0 → 0.19.1 - Update changelog - Update changelog contributor credits - Update dependencies * Update Portuguese Translation pt.po (ordinals#3837) * Updated Chinese translation (ordinals#3881) * Fix rune links for runes with no symbol (ordinals#3849) * Suppress printing sat_ranges by default (ordinals#3867) * Re-enter beta (ordinals#3884) * Update pointer specification (ordinals#3861) * Clarify that unused runes tags should not be used (ordinals#3885) * Migrate object.rs to snafu error handling (ordinals#3858) * Make index settings harder to misuse (ordinals#3893) * Don't unnecessarily insert into utxo cache when indexing addresses (ordinals#3894) * Remove trailing space from runes specification (ordinals#3896) * Serve responses with cross origin isolation headers (ordinals#3898) * List all Bitcoin Core wallets (ordinals#3902) * Make first first and last sat in range clickable (ordinals#3903) * Migrate Outgoing to SnafuError (ordinals#3854) * Update Bitcoin Core deploy to 27.1 (ordinals#3912) * Add sat_balance to address API (ordinals#3905) Co-authored-by: raph <raphjaph@protonmail.com> * Add Dutch translation to Ordinals Handbook (ordinals#3907) * Migrate chain.rs to snafu error (ordinals#3904) * Bump version to 0.20.0-dev (ordinals#3916) * Revert "Serve responses with cross origin isolation headers" (ordinals#3920) * Remove inscription content type counts from /status page (ordinals#3922) * Unified OUTPOINT_TO_UTXO_ENTRY table (ordinals#3915) - Upgrade `redb` to 2.1.1 - Remove `--index-spent-sats` - Remove redundant pointer handling in `index_inscriptions()` - Fix incorrect `is_output_spent()` results when not using `--index-sats` - Unify UTXO index data in `OUTPOINT_TO_UTXO_ENTRY` table - Read addresses from index when exporting * Add address field to `/r/inscription/:id` (ordinals#3891) * Add inscriptions and runes details to address API endpoint (ordinals#3924) * Release 0.20.0 (ordinals#3928) - Bump ord version: 0.19.1 → 0.20.0 - Bump ordinals version: 0.0.9 → 0.0.10 - Update changelog - Update changelog contributor credits - Update dependencies --------- Co-authored-by: Anchor <49644098+TheHeBoy@users.noreply.github.com> Co-authored-by: Casey Rodarmor <casey@rodarmor.com> Co-authored-by: 0xArtur <metaverseartur@gmail.com> Co-authored-by: Dr.JingLee <95461562+DrJingLee@users.noreply.github.com> Co-authored-by: nine <118634361+cryptoni9n@users.noreply.github.com> Co-authored-by: Bohdan Cryptolions <37701692+ansigroup@users.noreply.github.com> Co-authored-by: raph <raphjaph@protonmail.com> Co-authored-by: Patrick Collins <patrick@collinatorstudios.com> Co-authored-by: Tibebtc <tibedekock@live.nl> Co-authored-by: partialord <178683722+partialord@users.noreply.github.com> Co-authored-by: Eloc <42568538+elocremarc@users.noreply.github.com> Co-authored-by: twosatsmaxi <vashalpesh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of fix for #3192
converted src/outgoing.rs to use snafu instead of anyhow errors