Increase default maximum index size for non-regtest chains #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ordinal index, stored in <ORD_DATA_DIR>/index.redb, is a redb database, which grows dynamically. However, the maximum size that the database can grow to must be declared up-front, to avoid expensive region allocation operations on insert. We've been using 10 MiB as the default index size, which is too small for anything but testing. This commit changes the default maximum index size to 1 TiB on mainnet, testnet, and signet, and leaves it at 10 MiB on regtest. 1 TiB is more than needed, as even the mainnet database is only ~50 GiB, but allocating a database is fast enough, so it doesn't hurt to over provision and not have to think about it. For testing though, which is done with `--chain=regtest`, we want database allocation is fast, and 10 MiB is more than enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordinal index, stored in <ORD_DATA_DIR>/index.redb, is a redb
database, which grows dynamically. However, the maximum size that the
database can grow to must be declared up-front, to avoid expensive
region allocation operations on insert. We've been using 10 MiB as the
default index size, which is too small for anything but testing.
This commit changes the default maximum index size to 1 TiB on mainnet,
testnet, and signet, and leaves it at 10 MiB on regtest. 1 TiB is more
than needed, as even the mainnet database is only ~50 GiB, but
allocating a database is fast enough, so it doesn't hurt to over
provision and not have to think about it. For testing though, which is
done with
--chain=regtest, we want database allocation is fast, and 10MiB is more than enough.