Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make inscription type more flexible #892

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Make inscription type more flexible #892

merged 6 commits into from
Dec 6, 2022

Conversation

casey
Copy link
Collaborator

@casey casey commented Dec 6, 2022

We need to be quite lenient in what inscriptions we accept, to maintain global consensus over symbols.

Ideally, this means performing a minimum of validity checks, since the more validity checks we have and the more complex they are, the more likely we'll accidentally change them and change the set of valid inscriptions, and the more likely that different implementations will disagree about the set of valid inscriptions.

This PR converts the inscription enum to a struct, and removes all validity checks associated with content and content type. This isn't strictly necessary at the moment, but it'll be more code churn the longer we wait to do it.

@casey casey changed the title Convert inscription enum to struct Make inscription type more flexible Dec 6, 2022
@casey casey enabled auto-merge (squash) December 6, 2022 19:29
@casey casey merged commit e84da82 into master Dec 6, 2022
@casey casey deleted the flexible-inscriptions branch December 6, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant