feat: ✨ [NEW FEATURE]Choose which identity matching algorithm has to be run #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![create-issue-branch[bot]](https://avatars.githubusercontent.com/in/36017?s=60&v=4){kind=small}
[skip ci]
create-issue-branch
bot
added
AI-issue
create-issue-branch
bot
changed the title
Add match algorithms list and seeder issue: #479
Add selected algorithm to duplicates and crews migrations issue: #479
Font component and route to choose the algo issue: #479
Fix: wrong model name in seeding issue: #479
Run compute with the right algorithm and return the duplicates from that one only issue: #479
Update last duplicate check to work with multiple algos issue: #479
Updates since last run indicator fix issue: #479
Usable frontend issue: #479
Choose algorithm permissions issue: #479
Choose algorithm request validation issue: #479
Default to Levenshtein issue: #479
Remove static text issue: #479
Added tests issue: #479
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue description
Description of the desired solution
We had a first algo that used the Levenstein distance between different fields. This method had the advantage of comparing all fields, not just the best descriptive value (BDV) and applies weighted comparison.
Then we worked on a solution that used phonetics to compare the different items, but this method only compared BDV.
For now, it's up to us to choose (in the code) which algo to run. And once we've chosen an algo, that's the one that's run, period.
What would be nice is to be able to let the user choose the algo.
In duplicate, we could imagine a dropdown with the algos and the user choosing which algo to run on the data in his team.
Resolution path
Top of my head :
This is just a resolution idea that might need to be discussed.
Duplicate algorithm should have the same structure (same signature, same return type, ...) so it is not a problem to call one or another.
If the request is associated with a problem, please specify it.
Additional information
closes #479