Issues: Index, Create and Show page updates

[azenMatt]

GitHub Issues is evolving! 🥳

You may have seen discussion posts for exciting new features making their way to issues, such as:

• Issue types
• Sub-issues
• Advanced search (coming soon)

This new functionality is built on top of a UI rewrite of issues, which we would love your feedback on!

The aim of this rewrite was to clear up technical debt, allowing us to move faster in bringing new functionality to issues. With this in mind our goal has been parity with the existing experience. It should feel very familiar with only a few minor cosmetic tweaks.

The experiences that have been included so far in these updates are:

• The repository issues index
• The main issue body itself (what we call the 'show' page)
• The issue creation experience

The milestones, labels and /issues dashboard pages have not yet been migrated.

If you do come across anything not working as expected then please post your feedback below, thank you!

Guidelines

• I have read the above statement and can confirm my post is relevant to the GitHub feature areas Issues and/or Projects.

[jarrodldavis]

Are there plans to support customizing the subscription to issues? For example, here is an issue in microsoft/typescript:

Clicking on the "Customize" link leads me to this modal:

I was very confused when I landed on an issue in getsentry/spotlight and the "Customize" link was missing next to "Notifications" in the sidebar:

This appears to be because that repository is participating in this beta. This isn't particularly clear on the show page since only the issues index page has the Beta label.

[jarrodldavis]

I really hope you reconsider that decision since this is a feature I use all the time. I think instead of sunsetting it, you should do some real user testing to make sure people are actually aware of it, since hiding these useful options behind a barely-visible link above a prominent button isn't exactly the best path to user adoption. I also hope this doesn't bode poorly for similar features such as the customization options for watching repositories.

[azenMatt]

Thanks for the feedback @jarrodldavis - I have sent this on to the notifications PM who owns this decision.

[rdsedmundo]

I was absolutely confused for not being able to find this option in a specific repository, while seeing it in others. Was this beta enabled at the repo level instead of the Github user accessing the page itself? I think that's odd—I went to feature preview wanting to disable it because of the lack of this option and couldn't find it.

The rest of design looks like a change for the better, but I'm disappointed that this critical missing feature wasn't prioritized since Jul 23 once this was first reported, and I have no way to get out of beta.

And by the way—within the issue itself you should also include the "Beta — Give feedback" thing, it's only available in the issue list itself, so this is why it took me a minute to notice the design was different.

[azenMatt]

Hey @jarrodldavis @rdsedmundo - I have been though this with the Notifications team - we are going to work on adding this back into to this experience.

[RokeJulianLockhart]

I have been though this with the Notifications team - we are going to work on adding this back into to this experience.

@azenMatt, the ability to subscribe to solely issue closure and reopening is the primary reason I ever use GitHub over its competitors. I have open issues for this functionality in Discussions, GitLab, Gitea, and Bugzilla because it's so important to me.

[beingminimal]

@azenMatt Our teams heavily relies on Tasklists for managing complex projects across multiple GitHub organizations. We're eager to adopt the upcoming sub-issues and issue types feature to enhance our workflow significantly. We request early access to the beta program to provide valuable feedback. Thank You.

Can you please share advance search is coming for GitHub Projects or in global search of github for issues?

[azenMatt]

Advanced search will be in three phases,

1. Repo level
2. The github.com/issues global dashboard
3. Projects

I replied in the other sub-issues thread about beta access 😄

[beingminimal]

@azenMatt ok i have replied there, and do we need to be flagged for this advance search feature also? Just curious to know. Thanks

[xPaw]

1. This loading indicator whenever changing filters or switching to open/closed issues is not obvious (took me a while to notice when clicking a link on the left side), and is causing layout shifts when it shows up.
   

2. The issue state icons are flickering whenever the filters change:

20240804-RC7MDe3J.mp4

3. The open/closed issue counts are wrong on page load:

20240804-wdyaWhgu.mp4

4. When the 'new issues' modal shows up, the entire page shifts on Windows/Chrome because it disables the body scrollbar (designed on a mac™)

[azenMatt]

Thank you for taking the time to share these @xPaw

1. Good point - we are looking to see if we can either remove this spinner or put it somewhere that won't cause a shift
2. The team are looking into what is causing this and will get it resolved
3. We are also looking into this and will get it fixed
4. Guilty 🍏. We will get this fixed

[xPaw]

Don't completely remove a loading indicator, you could hook it up to the blue progress bar that appears on top of the page when navigating between pages.

Another thing I noticed is when the issue list loads, other information like number of comments/assigned person loads later. Loading information at different intervals is pretty annoying and feels slower than it needs to be.

[azenMatt]

How are you feeling about this now @xPaw since we've made some tweaks to the experience?

[xPaw]

The issue status icons still flicker when the list refreshes.

[azenMatt]

Thanks - we are tracking a fix for this

[sampart]

If I comment on an issue to which I'm not currently subscribed, , the button under "Notifications" on the right still says "Subscribe" even after the comment is posted. If I refresh the page, it correctly shows "Unsubscribe" (because posting the comment as subscribed me). It'd be nice if this button could update its state dynamically to reflect the actual situation. Thanks

[azenMatt]

Thanks @sampart - we will get this fixed

[MonstraG]

I tried creating an issue in https://github.com/getsentry/sentry-javascript/issues/new?template=feature.yml and that failed with

GraphQL error: FORBIDDEN: You cannot override the issue type assigned to the template (path: createIssue) (Persisted query id: 1b60066c55f48afb1363a2c618ea4556)

(I wasn't trying to override issue type)

[azenMatt]

Looking at this now...

[azenMatt]

Fix is being deployed....

[azenMatt]

The fix is in production - apologies for the disruption

[MonstraG]

I don't seem to be able to disable this beta:

So I cannot work lol.

[sunnyi101]

Thanks @MonstraG - this has been fixed

[PatchMixolydic]

This appears to have regressed:

[lishaduck]

Obviously a larger change, but could it be made to the PRs view too?
I don't really care one way or the other if this is how issues looks, but it's inconsistent.

Also, the beta marker takes up a whole line. Could it be moved down? As it is, there's a big white bar above the search bar.

[sunnyi101]

@lishaduck Thank you for the feedback! Which change are you referring to?

[lishaduck]

The updates as a whole are jarring, as switching between the prs view and issues view was jarring. It looks to have been reverted now.

[MatthiasPortzel]

In this beta the border on the corners on the issue list box gets cut off—this UI is not ready for general use.

[sunnyi101]

@MatthiasPortzel Thank you for the feedback! We'll get this fixed. Are there any other issues you are experiencing?

[etiennebarrie]

Keyboard shortcuts don't work. I use j/k/o all the time.

[sunnyi101]

@etiennebarrie thanks for the feedback, we are working to get that fixed.

[azenMatt]

This fix is rolling out today

[paarthmadan]

Switching between the open and closed view on the Issues view has a jarring loading state. It seems there's deferred loading on the "status" icons which changes the width ever-so-slightly

[sunnyi101]

Thank you for the feedback! We're looking into this 🙂

[azenMatt]

We've made some changes here - how is it feeling for you now?

[joulev]

Not sure if this has been reported yet, but the profile picture is not aligned to the middle perfectly for issue comments. Screenshot below taken from this issue comment.

[sunnyi101]

Thank you for the feedback! We will look into this 👍🏽

[xnox]

I am not sure, but possibly @ mentions are broken in issues for beta/preview projects.

[sunnyi101]

Great! Please let us know if you have any other feedback 😀

[TaylorBloom129]

Hey @sunnyi101 looks like this is still happening for us again

[mamccorm]

+1, it seems to disappear then return again

[sunnyi101]

@mamccorm this issue has been fixed. Please let me know if you're still experiencing any issues!

[mamccorm]

Sounds great, I certainly will, thanks for the resolution

[cpanato]

[xnox]

sure, here, but this org/community is not in beta - note how the comment box looks "old" compared to the ones that look more minimalist and "don't work"

[cpanato]

ahh i see

[edhgoose]

Something very strange is happening for me when trying to reply to an issue. I'm trying to reply, and tag someone in an issue and the screen is jumping all over the place. And the @ dialog to choose who to reply is never appearing.

All I do in the following video is type @brian. I never touch the trackpad, only the keyboard - and yet the screen jumps all over the place.

Screen.Recording.2024-08-27.at.22.42.28-2.mov

It does not occur in this window on Discussions.

[xnox]

Google Chrome on Linux x86-64 for me

[sunnyi101]

Thanks for reporting! We are looking into it

[edhgoose]

Google Chrome, on a Mac: Version 127.0.6533.120

And I've just loaded up a new version of Chrome - Version 128.0.6613.85 and it seems to be behaving.

I do see this now though:

[sunnyi101]

@edhgoose @xnox @TaylorBloom129 this issue has been fixed. Please let me know if you're still experiencing any issues!

[edhgoose]

Thanks @sunnyi101 - looks to be good now. Will report back if anything changes!

[HeyBanditoz]

super minor nit, but will the connecting lines between consecutive comments be added back? they still exist for other "event" types (like label add, new commit)

---

[sunnyi101]

@HeyBanditoz Thanks for the feedback! We'll look into it 👍

[rajbos]

Changing an issue from type A to type B can only be done from the issue overview. I was searching for 5 minutes before I found it there.
I would expect it to be in the issue editor, if need be on the ... button.

[azenMatt]

Thanks @rajbos - we are going to change this around and make it closer to the rest of the meta data on the sidebar.

[artechejl]

I do not like the modal window when opening an issue, I prefer a new window as it was before. It is slow and does not allow ctrl+f search easily...

[azenMatt]

Thanks for the feedback @artechejl - we will take this into consideration.

[levrik]

When reloading an issue while being scrolled far to the bottom, the scroll position doesn't get restored due to the lazy-loading of comments. Would be great to have this fixed as browser often reload after a tab was put to sleep for example and then I loose the scroll position.

[sunnyi101]

Thank you for the feedback!
We will look into this :)

[jarpoole]

Very small nitpick: While it is extremely useful that the issue number is clickable in the GitHub projects slideout (please do not remove this) it is odd that it links to itself on the issues page. I have curiously clicked it a couple of times (not sure what I was expecting) only to end up exactly where I started. I assume this is just a side-effect of both views using the same implementation...

[sunnyi101]

Thank you for the feedback! We will look into this :)

[Zopolis4]

This feels like a lot of screen real estate being dedicated to assigned issues, something that depends a lot on the particular repository (i.e. some repos don't really assign issues to anybody, some do) in comparison to the list of comments, which is information valuable in all repositories.

maybe it would feel a little less jarring if there was nothing there instead of an empty profile spot? although i guess it is encouraging ppl to assign issues by clearly recording that nobody has been assigned.

that being said, this might just be me getting used to the change.

[sunnyi101]

Thank you so much for feedback!

[bjorn3]

If immediately after loading I scroll to the bottom of an issue with a lot of comments, a second or so later a bunch of extra comments appear pushing the comment box out of view. And in any case having to wait before I can see the most recent comments is pretty annoying.

[bjorn3]

The issues list just glitched out for me after I pressed the back button while looking at an issue. I don't see any issues anymore. Refreshing fixes it and I can't reproduce.

[sunnyi101]

Let us know if it happens again!

[PatchMixolydic]

The font weights for titles and labels appear to be backwards:

The bold label text is especially distracting when trying to scan through the issues list (or, for certain classes of people, when trying to read an issue that requires careful understanding).

[sunnyi101]

Thank you for the feedback! We are looking into this

[JorgeCepeda]

With the new UI the issue/PR's author username isn't shown on the browser, I think that's important, I won't memorize profile pictures.

[PatchMixolydic]

The username seems to disappear at a width of 1024px. No clue why; there's plenty of space for it.

[sunnyi101]

@JorgeCepeda Thank you for the feedback! Could you please send me a screenshot of where you are seeing this issue?

[jakebailey]

On the new issue page, scrolling down in a long thread ends the thread without any comments, instead showing a "Load all button"; I appreciate being able to load everything all at once, but I get no context at all as to the most recent comments:

[sunnyi101]

Thank you for the feedback! We will look into this.

[cynecx]

I am a heavy mobile user and it seems like this has regressed really bad. This is on 75% zoom and there is so much wasted space:

Compared to the PR page, which seems much more compact (as it should be on mobile):

EDIT: So sorry about the huge images I just made direct screenshots on the mobile.

[SpriteOvO]

I miss the old avatar position.

Before, the avatars were on the left side as a separate column, and when scrolling quickly I could easily identify where each comment started and ended.

Now the avatars are inside the comment box and are small. The spacing between each comment is also very tight. I always get visual fatigue when scrolling quickly.

Can we revert the old avatar position or improve some of the spacing between comments? Discussion's spacing looks fine to me, and at least there's a "Write a reply" that always acts as a separator.

I also noticed in the screenshot that the right panel always showed up no matter where I scrolled in the old UI, but the new UI doesn't show it with scrolling.

[JorgeCepeda]

Here, an example in Rust's repo, the asignee's pfp is shown. 

[cynecx]

How can I opt-out for now? Considering it says this is a beta? The feature preview window doesn't list this beta feature so I can't really disable it for now.

[lolbinarycat]

found a ui bug when the name of an issue type contains a space, and you try to search for it using the graphical interface:

first click here:

then click on a type containing a space:

now you get an error: