Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto hide layers and save button in editor #1505

Merged
merged 2 commits into from
Apr 1, 2022
Merged

Conversation

johnnyblasta
Copy link
Collaborator

Hides layer selector button when only one layer is editable.
Hides save button when autosave option is true.
Closes #1494

Copy link
Contributor

@steff-o steff-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Chrome on Windows. There is a wider gap between the save button and the button next to it if layer selector is hidden. Probably because the layer button is inside the popover-container. Hide that div instead removes the gap.

image

@johnnyblasta
Copy link
Collaborator Author

Tested in Chrome on Windows. There is a wider gap between the save button and the button next to it if layer selector is hidden. Probably because the layer button is inside the popover-container. Hide that div instead removes the gap.

image

Made a fix that hides popover-container instead which makes the extra wide gap disappears

Copy link
Contributor

@steff-o steff-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still there are some strange stuff going in in the editor toolbar, but that's not because this PR. The add feature button is also wrapped in a popover-div that separates it from the other buttons a bit and the editor layer popover contains a body tag. But both those have been there for ages.

@johnnyblasta johnnyblasta merged commit 17be6fb into master Apr 1, 2022
@johnnyblasta johnnyblasta deleted the hide-buttons branch April 1, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor - hide tool buttons
2 participants