Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1476 and #1482 (correct styling upon exiting print view) #1514

Merged
merged 2 commits into from
May 30, 2022

Conversation

sweco-sedalh
Copy link
Contributor

@sweco-sedalh sweco-sedalh commented Apr 6, 2022

This PR contains fixes #1476 and fixes #1482.

It properly "resets" scaling by using the existing setLayerScale function using the "original" DPI value (currently hardcoded to 150 as in other parts of the code).

Selection style is corrected by setting the layer style rather than the style of individual features (fix written by @sweco-sefaed).

@leafisfalling
Copy link

How is it going for this issue? :)

@sweco-sedalh
Copy link
Contributor Author

It's waiting for review by a maintainer.

@Grammostola
Copy link
Contributor

We (the sponsoring organization) have of course tested it and it appears to solve the two issues referred to. It would be great if others could check it too, as both issues were found by others and neither issue was reproduced by our normal usage patterns. There is a potential discussion point around 150dpi.

@steff-o
Copy link
Contributor

steff-o commented May 12, 2022

Tested with the simplest of possible configurations. It solves the bugs as described in the linked issues and passes lint. So for me it is OK.

Regarding the potential discussion around 150 dpi: it is unfortunate that this PR keeps building on the antipattern of using constant values scattered in the code, but that was a problem that was already there so I think that is out of the scope for this PR anyway.

Copy link
Collaborator

@johnnyblasta johnnyblasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to solve the issues, so lets get it approved then.

@johnnyblasta johnnyblasta merged commit cbc181e into origo-map:master May 30, 2022
@sweco-sedalh sweco-sedalh deleted the fix/gh-1476 branch May 30, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print - incorrect style for highlighted/selected objects after print Icons rescaled after print
6 participants