fix: really disable print buttons while print preview map is loading

src/controls/print/print-component.js

@@ -1,5 +1,6 @@
 import olAttribution from 'ol/control/Attribution';
 import olScaleLine from 'ol/control/ScaleLine';
+import { unByKey } from 'ol/Observable';
 import { getPointResolution } from 'ol/proj';
 import TileImage from 'ol/source/TileImage';
 import TileWMSSource from 'ol/source/TileWMS';
@@ -326,12 +327,16 @@ const PrintComponent = function PrintComponent(options = {}) {
   const printInteractionToggle = PrintInteractionToggle({ map, target, mapInteractionsActive, pageSettings: viewer.getViewerOptions().pageSettings });
 
   const printToolbar = PrintToolbar();
-  map.getAllLayers().forEach((l) => {
-    // if we begin loading any data we want to disable the print buttons...
-    l.getSource().on(['tileloadstart', 'imageloadstart'], () => printToolbar.setDisabled(true));
-  });
-  // ...they then get re-enabled when the map has finished rendering
-  map.on('rendercomplete', () => printToolbar.setDisabled(false));
+
+  let mapLoadListenRefs;
+
+  function disablePrintToolbar() {
+    printToolbar.setDisabled(true);
+  }
+
+  function enablePrintToolbar() {
+    printToolbar.setDisabled(false);
+  }
 
   return Component({
     name: 'printComponent',
@@ -455,6 +460,8 @@ const PrintComponent = function PrintComponent(options = {}) {
       printMapComponent.dispatch('change:togglePrintLegend', { showPrintLegend });
     },
     close() {
+      unByKey(mapLoadListenRefs[0]);
+      unByKey(mapLoadListenRefs[1]);
       // GH-1537: remove layers temporarily added for print and unhide layers hidden for print
       viewer.getLayersByProperty('added-for-print', true).forEach((l) => viewer.removeLayer(l));
       viewer.getLayersByProperty('hidden-for-print', true).forEach((l) => {
@@ -554,6 +561,12 @@ const PrintComponent = function PrintComponent(options = {}) {
       }));
     },
     async onRender() {
+      function addMapLoadListeners() {
+        const startEvRef = map.on('loadstart', disablePrintToolbar);
+        const endEvRef = map.on('loadend', enablePrintToolbar);
+        return [startEvRef, endEvRef];
+      }
+      mapLoadListenRefs = addMapLoadListeners();
       printScale = 0;
       today = new Date(Date.now());
       viewerMapTarget = map.getTarget();

src/controls/print/print-toolbar.js

@@ -18,10 +18,10 @@ const PrintToolbar = function PrintToolbar() {
       pdfButton.on('click', this.dispatchPrint.bind(this));
     },
     dispatchExport() {
-      this.dispatch('PNG');
+      if (pngButton.getState() !== 'disabled') this.dispatch('PNG');
     },
     dispatchPrint() {
-      this.dispatch('PDF');
+      if (pdfButton.getState() !== 'disabled') this.dispatch('PDF');
     },
     onRender() {
       this.dispatch('render');
@@ -37,8 +37,13 @@ const PrintToolbar = function PrintToolbar() {
       </div>`;
     },
     setDisabled(disabled) {
-      pngButton.setState(disabled ? 'disabled' : 'initial');
-      pdfButton.setState(disabled ? 'disabled' : 'initial');
+      if (disabled) {
+        pngButton.setState('disabled');
+        pdfButton.setState('disabled');
+      } else {
+        pngButton.setState('initial');
+        pdfButton.setState('initial');
+      }
     }
   });
 };