fix: make getfeatureinfo requests not fail together #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeks to fix #2001 , in the alternative fashion.
Yes, I made
getFeatureInfoUrlless robust in a recent pr and I could still remedy that function. The only place it is being used though is in the function I am proposing to change, fromPromise.alltoPromise.allSettled. So ifgetFeatureInfoUrltrips for any reason, like assuming everything is json when something isn't, that featureInfo call is discarded rather than allowed to render all concurrent featureInfo calls useless.(The function in the PR is also somewhat rewritten for readability. I did not find it an easy read before)