Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix astroid version #3

Closed
wants to merge 1 commit into from
Closed

Conversation

TeaDove
Copy link

@TeaDove TeaDove commented Sep 26, 2023

Astroid 3.0.0 brokes flake8-warning with error:

Traceback (most recent call last):
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 188, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 147, in _get_module_details
    return _get_module_details(pkg_main_name, error)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/runpy.py", line 111, in _get_module_details
    __import__(pkg_name)
  File "/private/tmp/flake8-warnings/flake8_warnings/__init__.py", line 4, in <module>
    from ._flake8_plugin import Flake8Checker
  File "/private/tmp/flake8-warnings/flake8_warnings/_flake8_plugin.py", line 6, in <module>
    from ._finder import WarningFinder
  File "/private/tmp/flake8-warnings/flake8_warnings/_finder.py", line 10, in <module>
    from ._extractors import EXTRACTORS, Extractor, WarningInfo
  File "/private/tmp/flake8-warnings/flake8_warnings/_extractors/__init__.py", line 7, in <module>
    from ._warnings import WarningsExtractor
  File "/private/tmp/flake8-warnings/flake8_warnings/_extractors/_warnings.py", line 11, in <module>
    astroid.TryExcept,
AttributeError: module 'astroid' has no attribute 'TryExcept'

Binding 2.x version solves issue

@orsinium
Copy link
Member

Thank you for your contribution! Can we upgrade instead? Was TryExcept renamed?

@orsinium
Copy link
Member

The issue is resolved in #4 by @aliaksei-protchanka. I still appreciate your contribution. Thank you for bringing attention to the issue ❤️

@orsinium orsinium closed this Sep 28, 2023
@TeaDove
Copy link
Author

TeaDove commented Sep 28, 2023

@orsinium it's much better. Ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants