contrib: Add ptdrgn.py script to run interactively via ptpython #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptpython is a really excellent REPL library which provides great multiline history and editing support, as well as syntax highlighting, and a nice code completion UI. Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
|
(also pictured: drgn running with CTF support) |
Completion of drgn Objects *is* already possible in ptpython, but unfortunately the list of completions is alphabetical (except for underscored attributes, which are last). This means that default Object fields like "absent_" and "type_" are not distinguished from the Object member fields. Resolve this by detecting when the first completion is "absent_" and then moving all the non-default completions to the beginning of the list. The result is that Object members are enumerated first, followed by the default Object fields. Signed-off-by: Stephen Brennan <stephen.s.brennan@oracle.com>
|
It turns out that the Object completions were already there, but they're not easy to find since the first completion is usually |
|
Here it is for a kmem_cache: |
|
Eventually we can make this less hacky with something like #319, but this is really cool and there's no reason it can't go in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got around to getting Drgn working with ptpython and it's pretty glorious. One particular item that's great is that it has a good multi-line code editor, so you can write multi-line loops, etc, and get automatic indentation, and you can go back and fix mistakes prior to the current line. I added in C syntax highlighting for Drgn objects + types, and I'd like to at some point get it to do completion for object members.
The actual code doing it was just going to live in
~/bin/ptdrgn, but I figured I could at least share it. It's full of hacks and implementation details, but this is thecontribdirectory, so maaaybe it's ok?