use a custom Downloads.Downloader for installing GAP packages
#961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #961 +/- ##
=======================================
Coverage 75.80% 75.80%
=======================================
Files 51 51
Lines 4186 4187 +1
=======================================
+ Hits 3173 3174 +1
Misses 1013 1013
|
fingolfin
approved these changes
Jan 25, 2024
ThomasBreuer
added a commit
to ThomasBreuer/PackageManager
that referenced
this pull request
Sep 18, 2024
- avoid the call `JuliaImportPackage("Downloads")`,
which somehow does not work as expected in certain situations,
see oscar-system/GAP.jl/issues/1040
- update the code of the function such that it contains the changes from
oscar-system/GAP.jl/pull/961
(Yes, the new code looks ugly, and the next GAP.jl version will contain
support for the "call with catch *and* keyword arguments" situation.)
fingolfin
pushed a commit
to gap-packages/PackageManager
that referenced
this pull request
Sep 19, 2024
- avoid the call `JuliaImportPackage("Downloads")`,
which somehow does not work as expected in certain situations,
see oscar-system/GAP.jl/issues/1040
- update the code of the function such that it contains the changes from
oscar-system/GAP.jl/pull/961
(Yes, the new code looks ugly, and the next GAP.jl version will contain
support for the "call with catch *and* keyword arguments" situation.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to fix a problem with Julia 1.10, see oscar-system/Oscar.jl/pull/3222.