[ToricVarieties] Rename dual_cone into weight_cone

oscar-system · Aug 31, 2023 · 0f159c6 · 0f159c6
1 parent e08fe6f
commit 0f159c6
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 9 deletions.
diff --git a/docs/src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties.md b/docs/src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties.md
@@ -152,7 +152,7 @@ picard_index(v::NormalToricVarietyType)
 ```@docs
 polyhedral_fan(v::NormalToricVarietyType)
 cone(v::AffineNormalToricVariety)
-dual_cone(v::AffineNormalToricVariety)
+weight_cone(v::AffineNormalToricVariety)
 hilbert_basis(v::AffineNormalToricVariety)
 mori_cone(v::NormalToricVariety)
 nef_cone(v::NormalToricVariety)

diff --git a/experimental/Schemes/IdealSheaves.jl b/experimental/Schemes/IdealSheaves.jl
@@ -1264,7 +1264,7 @@ function IdealSheaf(X::NormalToricVariety, I::MPolyIdeal)
 
     # Now we need to create the inverse of alpha*.
     imgs_alpha_star = elem_type(help_ring)[]
-    for m in hilbert_basis(dual_cone(U))
+    for m in hilbert_basis(weight_cone(U))
       img = one(help_ring)
       for j in 1:length(indices)
         u_rho = matrix(ZZ,rays(X))[indices[j],:]

diff --git a/src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/attributes.jl b/src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/attributes.jl
@@ -1072,7 +1072,7 @@ Polyhedral cone in ambient dimension 2
 
 
 @doc raw"""
-    dual_cone(v::AffineNormalToricVariety)
+    weight_cone(v::AffineNormalToricVariety)
 
 Return the dual cone of the affine normal toric variety `v`.
 
@@ -1084,14 +1084,14 @@ Polyhedral cone in ambient dimension 2
 julia> antv = affine_normal_toric_variety(C)
 Normal, affine toric variety
 
-julia> dual_cone(antv)
+julia> weight_cone(antv)
 Polyhedral cone in ambient dimension 2
 
-julia> polarize(cone(antv)) == dual_cone(antv)
+julia> polarize(cone(antv)) == weight_cone(antv)
 true
 ```
 """
-@attr Cone dual_cone(v::AffineNormalToricVariety) = polarize(cone(v))
+@attr Cone weight_cone(v::AffineNormalToricVariety) = polarize(cone(v))
 
 
 @doc raw"""
@@ -1114,7 +1114,7 @@ julia> hilbert_basis(antv)
 [ 0   1]
 ```
 """
-@attr ZZMatrix hilbert_basis(v::AffineNormalToricVariety) = matrix(ZZ, hilbert_basis(dual_cone(v)))
+@attr ZZMatrix hilbert_basis(v::AffineNormalToricVariety) = matrix(ZZ, hilbert_basis(weight_cone(v)))
 
 
 _variable_ray_correspondence(v::NormalToricVarietyType) = Dict{RayVector, MPolyRingElem}(zip(rays(v), gens(cox_ring(v))))

diff --git a/src/deprecations.jl b/src/deprecations.jl
@@ -405,3 +405,5 @@ end
 @alias ishermitian_form is_hermitian_form
 @alias isquadratic_form is_quadratic_form
 @alias issymmetric_form is_symmetric_form
+
+@deprecate dual_cone(v::AffineNormalToricVariety) weight_cone(v)
diff --git a/src/exports.jl b/src/exports.jl
@@ -469,7 +469,6 @@ export double_coset
 export double_cosets
 export double_dual
 export dst
-export dual_cone
 export dual_continued_fraction_hirzebruch_jung
 export dual_matroid
 export dual_subdivision
@@ -1432,6 +1431,7 @@ export wdeglex
 export wdegrevlex
 export weakly_connected_components
 export weight
+export weight_cone
 export weight_ordering
 export weighted_projective_space
 export weyl_algebra

diff --git a/test/AlgebraicGeometry/ToricVarieties/toric_schemes.jl b/test/AlgebraicGeometry/ToricVarieties/toric_schemes.jl
@@ -9,7 +9,7 @@ using Test
   @testset "A simplicial (and not smooth) affine toric scheme" begin
     @test is_smooth(underlying_scheme(antv)) == is_smooth(antv)
     @test dim(underlying_scheme(antv)) == dim(antv)
-    @test polarize(cone(antv)) == dual_cone(antv)
+    @test polarize(cone(antv)) == weight_cone(antv)
     @test ngens(ambient_coordinate_ring(antv)) == nrows(hilbert_basis(antv)) == 3
   end