Add missed jacobi's

oscar-system · Jan 12, 2024 · 1c62750 · 1c62750
1 parent cf8621d
commit 1c62750
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/experimental/PlaneCurve/docs/src/non_plane_curves.md b/experimental/PlaneCurve/docs/src/non_plane_curves.md
@@ -23,6 +23,6 @@ in(P::Oscar.Geometry.ProjSpcElem, C::ProjCurve)
 curve_components(C::ProjCurve)
 is_irreducible(C::ProjCurve)
 reduction(C::ProjCurve)
-jacobi_ideal(C::ProjCurve)
+jacobian_ideal(C::ProjCurve)
 invert_birational_map(phi::Vector{T}, C::ProjCurve) where {T <: MPolyRingElem}
 ```
diff --git a/experimental/PlaneCurve/src/ProjCurve.jl b/experimental/PlaneCurve/src/ProjCurve.jl
@@ -2,7 +2,7 @@ export ProjCurve
 export curve_components
 export defining_ideal
 export is_irreducible
-export jacobi_ideal
+export jacobian_ideal
 export reduction
 
 import Oscar.defining_ideal
@@ -187,7 +187,7 @@ end
 ################################################################################
 
 @doc raw"""
-    jacobi_ideal(C::ProjCurve)
+    jacobian_ideal(C::ProjCurve)
 
 Return the Jacobian ideal of the defining ideal of `C`.
 
@@ -205,15 +205,15 @@ ideal(x^2, y^2*z, z^2)
 julia> C = Oscar.ProjCurve(I)
 Projective curve defined by the ideal(x^2, y^2*z, z^2)
 
-julia> Oscar.jacobi_ideal(C)
+julia> Oscar.jacobian_ideal(C)
 ideal(4*x*y*z, 2*x*y^2, 4*x*z, 4*y*z^2)
 ```
 """
-function Oscar.jacobi_ideal(C::ProjCurve)
+function Oscar.jacobian_ideal(C::ProjCurve)
     I = defining_ideal(C)
     R = base_ring(I)
     k = C.ambiant_dim - 1
-    M = jacobi_matrix(gens(I))
+    M = jacobian_matrix(gens(I))
     V = minors(M, k)
     filter!(!iszero, V)
     return ideal(R, V)

diff --git a/src/AlgebraicGeometry/Schemes/AffineSchemes/Objects/Attributes.jl b/src/AlgebraicGeometry/Schemes/AffineSchemes/Objects/Attributes.jl
@@ -799,7 +799,7 @@ end
 ## compute *some* representative of the Jacobian matrix of gens(modulus),
 ## forgetting about the denominators (contribution killed by modulus anyway)
 
-function _jacobi_matrix_modulus(X::AbsSpec{<:Ring, <:MPAnyQuoRing})
+function _jacobian_matrix_modulus(X::AbsSpec{<:Ring, <:MPAnyQuoRing})
   g = gens(modulus(underlying_quotient(OO(X))))
   L = base_ring(underlying_quotient(OO(X)))
   n = nvars(L)