Bump Hecke version

oscar-system · Sep 21, 2023 · 231d7b0 · 231d7b0
1 parent 35bf9a4
commit 231d7b0
Show file tree

Hide file tree

Showing 12 changed files with 50 additions and 50 deletions.
diff --git a/Project.toml b/Project.toml
@@ -28,7 +28,7 @@ AbstractAlgebra = "0.32.1"
 AlgebraicSolving = "0.3.3"
 DocStringExtensions = "0.8, 0.9"
 GAP = "0.9.4"
-Hecke = "0.21"
+Hecke = "0.22"
 JSON = "^0.20, ^0.21"
 Nemo = "0.36"
 Polymake = "0.11.1"

diff --git a/experimental/PlaneCurve/src/PlaneCurve.jl b/experimental/PlaneCurve/src/PlaneCurve.jl
@@ -469,8 +469,7 @@ julia> C = AffinePlaneCurve(y^2+x-x^3)
 Affine plane curve defined by -x^3 + x + y^2
 
 julia> Oscar.ring(C)
-(Quotient of multivariate polynomial ring by ideal(-x^3 + x + y^2), Map from
-Multivariate polynomial ring in 2 variables over QQ to Quotient of multivariate polynomial ring by ideal(-x^3 + x + y^2) defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(-x^3 + x + y^2), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
 ```
 """
 function ring(C::PlaneCurve)

diff --git a/experimental/Schemes/duValSing.jl b/experimental/Schemes/duValSing.jl
@@ -12,8 +12,7 @@ julia> I = ideal(R,[w,x^2+y^3+z^4])
 ideal(w, x^2 + y^3 + z^4)
 
 julia> Rq,_ = quo(R,I)
-(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map from
-Multivariate polynomial ring in 4 variables over QQ to Rq defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> X = Spec(Rq)
 Spectrum
@@ -75,8 +74,7 @@ julia> I = ideal(R,[w,x^2+y^3+z^4])
 ideal(w, x^2 + y^3 + z^4)
 
 julia> Rq,_ = quo(R,I)
-(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map from
-Multivariate polynomial ring in 4 variables over QQ to Rq defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> J = ideal(R,[x,y,z,w])
 ideal(x, y, z, w)
@@ -150,8 +148,7 @@ julia> I = ideal(R,[w,x^2+y^3+z^4])
 ideal(w, x^2 + y^3 + z^4)
 
 julia> Rq,_ = quo(R,I)
-(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map from
-Multivariate polynomial ring in 4 variables over QQ to Rq defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(w, x^2 + y^3 + z^4), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> J = ideal(R,[x,y,z,w])
 ideal(x, y, z, w)

diff --git a/src/Combinatorics/SimplicialComplexes.jl b/src/Combinatorics/SimplicialComplexes.jl
@@ -305,8 +305,7 @@ Return the Stanley-Reisner ring of the abstract simplicial complex `K`.
 julia> K = SimplicialComplex([[1,2,3],[2,3,4]]);
 
 julia> stanley_reisner_ring(K)
-(Quotient of multivariate polynomial ring by ideal(x1*x4), Map from
-Multivariate polynomial ring in 4 variables over QQ to Quotient of multivariate polynomial ring by ideal(x1*x4) defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(x1*x4), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
 ```
 """
 function stanley_reisner_ring(K::SimplicialComplex)
@@ -325,8 +324,7 @@ Return the Stanley-Reisner ring of the abstract simplicial complex `K`, as a quo
 julia>  R, _ = ZZ["a","b","c","d","e","f"];
 
 julia> stanley_reisner_ring(R, real_projective_plane())
-(Quotient of multivariate polynomial ring by ideal(a*b*c, a*b*d, a*e*f, b*e*f, a*c*f, a*d*e, c*d*e, c*d*f, b*c*e, b*d*f), Map from
-Multivariate polynomial ring in 6 variables over ZZ to Quotient of multivariate polynomial ring by ideal(a*b*c, a*b*d, a*e*f, b*e*f, a*c*f, a*d*e, c*d*e, c*d*f, b*c*e, b*d*f) defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(a*b*c, a*b*d, a*e*f, b*e*f, a*c*f, a*d*e, c*d*e, c*d*f, b*c*e, b*d*f), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
 ```
 """
 stanley_reisner_ring(R::MPolyRing, K::SimplicialComplex) = quo(R, stanley_reisner_ideal(R, K))

diff --git a/src/Modules/ModulesGraded.jl b/src/Modules/ModulesGraded.jl
@@ -240,8 +240,7 @@ julia> R, (x, y) = graded_polynomial_ring(QQ, ["x", "y"])
 (Graded multivariate polynomial ring in 2 variables over QQ, MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}[x, y])
 
 julia> S, _ = quo(R, [x*y])
-(Quotient of multivariate polynomial ring by ideal(x*y), Map from
-R to S defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(x*y), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> F = free_module(S, 2)
 Free module of rank 2 over S

diff --git a/src/Modules/UngradedModules.jl b/src/Modules/UngradedModules.jl
@@ -5570,8 +5570,7 @@ julia> F2 = free_module(R, 2)
 Free module of rank 2 over Multivariate polynomial ring in 3 variables over QQ
 
 julia> V, f = hom(F1, F2)
-(hom of (F1, F2), Map from
-V to Set of all homomorphisms from Free module of rank 3 over Multivariate polynomial ring in 3 variables over QQ to Free module of rank 2 over Multivariate polynomial ring in 3 variables over QQ defined by a julia-function with inverse)
+(hom of (F1, F2), Map: hom of (F1, F2) -> set of all homomorphisms from Free module of rank 3 over Multivariate polynomial ring in 3 variables over QQ to Free module of rank 2 over Multivariate polynomial ring in 3 variables over QQ)
 
 julia> f(V[1])
 Map with following data
@@ -5598,8 +5597,7 @@ julia> F2 = graded_free_module(Rg, [3,5])
 Graded free module Rg^1([-3]) + Rg^1([-5]) of rank 2 over Rg
 
 julia> V, f = hom(F1, F2)
-(hom of (F1, F2), Map from
-V to Set of all homomorphisms from Graded free module Rg^1([-1]) + Rg^2([-2]) of rank 3 over Rg to Graded free module Rg^1([-3]) + Rg^1([-5]) of rank 2 over Rg defined by a julia-function with inverse)
+(hom of (F1, F2), Map: hom of (F1, F2) -> set of all homomorphisms from Graded free module Rg^1([-1]) + Rg^2([-2]) of rank 3 over Rg to Graded free module Rg^1([-3]) + Rg^1([-5]) of rank 2 over Rg)
 
 julia> f(V[1])
 F1 -> F2

diff --git a/src/Rings/MPolyQuo.jl b/src/Rings/MPolyQuo.jl
@@ -213,8 +213,7 @@ julia> R, (x, y, z) = polynomial_ring(QQ, ["x", "y", "z"])
 (Multivariate polynomial ring in 3 variables over QQ, QQMPolyRingElem[x, y, z])
 
 julia> A, _ = quo(R, ideal(R, [y-x^2, z-x^3]))
-(Quotient of multivariate polynomial ring by ideal(-x^2 + y, -x^3 + z), Map from
-Multivariate polynomial ring in 3 variables over QQ to A defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(-x^2 + y, -x^3 + z), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> a = ideal(A, [x-y])
 ideal(x - y)
@@ -243,8 +242,7 @@ julia> R, (x, y, z) = polynomial_ring(QQ, ["x", "y", "z"])
 (Multivariate polynomial ring in 3 variables over QQ, QQMPolyRingElem[x, y, z])
 
 julia> A, _ = quo(R, ideal(R, [y-x^2, z-x^3]))
-(Quotient of multivariate polynomial ring by ideal(-x^2 + y, -x^3 + z), Map from
-Multivariate polynomial ring in 3 variables over QQ to A defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(-x^2 + y, -x^3 + z), Map: multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> a = ideal(A, [x-y])
 ideal(x - y)
@@ -845,8 +843,9 @@ julia> typeof(x)
 QQMPolyRingElem
 
 julia> p
-Map from
-Multivariate polynomial ring in 2 variables over QQ to A defined by a julia-function with inverse
+Map defined by a julia-function with inverse
+  from multivariate polynomial ring in 2 variables over QQ
+  to quotient of multivariate polynomial ring by ideal(x^2 - y^3, x - y)
 
 julia> p(x)
 x
@@ -858,8 +857,7 @@ MPolyQuoRingElem{QQMPolyRingElem}
 julia> S, (x, y, z) = graded_polynomial_ring(QQ, ["x", "y", "z"]);
 
 julia> B, _ = quo(S, ideal(S, [x^2*z-y^3, x-y]))
-(Quotient of multivariate polynomial ring by ideal(x^2*z - y^3, x - y), Map from
-S to B defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(x^2*z - y^3, x - y), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> typeof(B)
 MPolyQuoRing{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}}
@@ -1167,8 +1165,7 @@ Given a homogeneous element `f` of a $\mathbb Z$-graded affine algebra, return t
 julia> R, (x, y, z) = graded_polynomial_ring(QQ, ["x", "y", "z"] );
 
 julia> A, p = quo(R, ideal(R, [y-x, z^3-x^3]))
-(Quotient of multivariate polynomial ring by ideal(-x + y, -x^3 + z^3), Map from
-R to A defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(-x + y, -x^3 + z^3), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> f = p(y^2-x^2+z^4)
 -x^2 + y^2 + z^4
@@ -1367,8 +1364,9 @@ julia> L = homogeneous_component(R, 2);
 julia> HC = gens(L[1]);
 
 julia> EMB = L[2]
-Map from
-R_[2] of dim 10 to R defined by a julia-function with inverse
+Map defined by a julia-function with inverse
+  from r_[2] of dim 10
+  to graded multivariate polynomial ring in 4 variables over QQ
 
 julia> for i in 1:length(HC) println(EMB(HC[i])) end
 z^2
@@ -1391,9 +1389,10 @@ julia> L = homogeneous_component(A, 2);
 julia> HC = gens(L[1]);
 
 julia> EMB = L[2]
-Map from
-Quotient space over:
-Rational field with 7 generators and no relations to A defined by a julia-function with inverse
+Map defined by a julia-function with inverse
+  from quotient space over:
+  Rational field with 7 generators and no relations
+  to quotient of multivariate polynomial ring by ideal(-x*z + y^2, -w*z + x*y, -w*y + x^2)
 
 julia> for i in 1:length(HC) println(EMB(HC[i])) end
 z^2
@@ -1425,9 +1424,10 @@ julia> L = homogeneous_component(S, [2,1]);
 julia> HC = gens(L[1]);
 
 julia> EMB = L[2]
-Map from
-homogeneous component of Graded multivariate polynomial ring in 5 variables over QQ of degree Element of G with components [2 1]
- to S defined by a julia-function with inverse
+Map defined by a julia-function with inverse
+  from homogeneous component of Graded multivariate polynomial ring in 5 variables over QQ of degree Element of G with components [2 1]
+
+  to graded multivariate polynomial ring in 5 variables over QQ
 
 julia> for i in 1:length(HC) println(EMB(HC[i])) end
 x[2]^2*y[3]
@@ -1449,9 +1449,10 @@ julia> L = homogeneous_component(A, [2,1]);
 julia> HC = gens(L[1]);
 
 julia> EMB = L[2]
-Map from
-Quotient space over:
-Rational field with 7 generators and no relations to A defined by a julia-function with inverse
+Map defined by a julia-function with inverse
+  from quotient space over:
+  Rational field with 7 generators and no relations
+  to quotient of multivariate polynomial ring by ideal(x[1]*y[1] - x[2]*y[2])
 
 julia> for i in 1:length(HC) println(EMB(HC[i])) end
 x[2]^2*y[3]

diff --git a/src/Rings/NumberField.jl b/src/Rings/NumberField.jl
@@ -56,6 +56,8 @@ elem_type(::NfNSGen{T, S}) where {T, S} = NfNSGenElem{T, S}
 
 elem_type(::Type{NfNSGen{T, S}}) where {T, S} = NfNSGenElem{T, S}
 
+is_simple(::NfNSGen) = false
+
 ################################################################################
 #
 #  Constructors
@@ -523,6 +525,11 @@ for t in [Base.Integer, Base.Rational{<:Base.Integer}, ZZRingElem, QQFieldElem]
   end
 end
 
+function (K::NfNSGen{T, S})(x::NfAbsOrdElem{NfNSGen{T, S}, <:Any}) where {T, S}
+  @req nf(parent(x)) === K "Parent of element must be an order of the number field"
+  return elem_in_nf(x)
+end
+
 ################################################################################
 #
 #  Denominator (for absolute fields)

diff --git a/src/Rings/PBWAlgebraQuo.jl b/src/Rings/PBWAlgebraQuo.jl
@@ -232,8 +232,9 @@ julia> Q
 (PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z)/two_sided_ideal(x^2, y^2, z^2)
 
 julia> q
-Map from
-PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z to (PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z)/two_sided_ideal(x^2, y^2, z^2) defined by a julia-function with inverse
+Map defined by a julia-function with inverse
+  from pBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z
+  to (PBW-algebra over Rational field in x, y, z with relations y*x = -x*y, z*x = -x*z, z*y = -y*z)/two_sided_ideal(x^2, y^2, z^2)
 ```
 
 !!! note

diff --git a/src/Rings/mpoly-affine-algebras.jl b/src/Rings/mpoly-affine-algebras.jl
@@ -79,8 +79,7 @@ julia> I = ideal(R, [x^2, y^3])
 ideal(x^2, y^3)
 
 julia> A, _ = quo(R, I)
-(Quotient of multivariate polynomial ring by ideal(x^2, y^3), Map from
-R to A defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(x^2, y^3), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> L = monomial_basis(A)
 6-element Vector{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}}:
@@ -133,8 +132,7 @@ julia> I = ideal(R, [x^2])
 ideal(x^2)
 
 julia> A, _ = quo(R, I)
-(Quotient of multivariate polynomial ring by ideal(x^2), Map from
-R to A defined by a julia-function with inverse)
+(Quotient of multivariate polynomial ring by ideal(x^2), Map: graded multivariate polynomial ring -> quotient of multivariate polynomial ring)
 
 julia> L = monomial_basis(A, 3)
 2-element Vector{MPolyDecRingElem{QQFieldElem, QQMPolyRingElem}}:

diff --git a/src/Rings/mpoly-graded.jl b/src/Rings/mpoly-graded.jl
@@ -1288,8 +1288,9 @@ homogeneous component of Graded multivariate polynomial ring in 5 variables over
 julia> FG = gens(L[1]);
 
 julia> EMB = L[2]
-Map from
-S_[1 1] of dim 6 to S defined by a julia-function with inverse
+Map defined by a julia-function with inverse
+  from s_[1 1] of dim 6
+  to graded multivariate polynomial ring in 5 variables over QQ
 
 julia> for i in 1:length(FG) println(EMB(FG[i])) end
 x[2]*y[3]

diff --git a/src/Rings/mpolyquo-localizations.jl b/src/Rings/mpolyquo-localizations.jl
@@ -308,8 +308,9 @@ Localization
   at complement of prime ideal(y - 1, x - a)
 
 julia> iota
-Map from
-RQ to Localization of quotient of multivariate polynomial ring at complement of prime ideal defined by a julia-function
+Map defined by a julia-function
+  from quotient of multivariate polynomial ring by ideal(2*x^2 - y^3, 2*x^2 - y^5)
+  to localization of quotient of multivariate polynomial ring at complement of prime ideal
 ```
 """ localization(A::MPolyQuoRing, U::AbsMPolyMultSet)