Trivial cleanups (#4130)

oscar-system · Sep 20, 2024 · 33595be · 33595be
1 parent a9cfa90
commit 33595be
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Rings/mpoly-graded.jl b/src/Rings/mpoly-graded.jl
@@ -1453,7 +1453,7 @@ end
 #########################################
 function add_relshp(R, S, h)
   #this assumes that h is essentially a canonical map from R -> S
-  D = get_attribute!(R, :relshp, Dict{Any, Any}())::Dict{Any, Any}
+  D = get_attribute!(Dict{Any, Any}, R, :relshp)::Dict{Any, Any}
   if haskey(D, S)
     error("try to add double")
   end

diff --git a/src/Rings/mpolyquo-localizations.jl b/src/Rings/mpolyquo-localizations.jl
@@ -1357,7 +1357,7 @@ end
   inverse_name=:_0
   r = length(denoms)
   kk = coefficient_ring(R)
-  A, t = polynomial_ring(kk, vcat([Symbol(String(inverse_name)*"$k") for k in 1:r],
+  A, t = polynomial_ring(kk, vcat([Symbol(inverse_name,k) for k in 1:r],
                                   symbols(P), symbols(R)); cached=false)
   r = length(denoms)
   theta = t[1:r]
@@ -2330,7 +2330,7 @@ end
   f = denominators(inverted_set(L))
   f = sort(f; by=total_degree, rev=true)
   r = length(f)
-  A, phi, t = _add_variables_first(R, [Symbol(String(inverse_name)*"$k") for k in 1:r])
+  A, phi, t = _add_variables_first(R, [Symbol(inverse_name,k) for k in 1:r])
   theta = t[1:r]
   I = ideal(A, [one(A)-theta[k]*phi(f[k]) for k in 1:r])
   ordering = degrevlex(gens(A)[r+1:end])
@@ -2363,7 +2363,7 @@ end
   f = denominators(inverted_set(L))
   f = sort(f; by=total_degree, rev=true)
   r = length(f)
-  A, phi, t = _add_variables_first(R, [Symbol(String(inverse_name)*"$k") for k in 1:r])
+  A, phi, t = _add_variables_first(R, [Symbol(inverse_name,k) for k in 1:r])
   theta = t[1:r]
   I = ideal(A, [phi(g) for g in gens(modulus(underlying_quotient(L)))]) + ideal(A, [one(A)-theta[k]*phi(f[k]) for k in 1:r])
   ordering = degrevlex(gens(A)[r+1:end])