Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Lars Kastner <lkastner@users.noreply.github.com>
  • Loading branch information
antonydellavecchia and lkastner committed Feb 22, 2024
1 parent a5d5968 commit 6933db9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion src/Serialization/containers.jl
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ end
function load_object(s::DeserializerState, ::Type{<: Vector}, params::Type)
load_node(s) do v
if serialize_with_id(params)

loaded_v = params[load_ref(s, x) for x in v]
else
loaded_v = params[]
Expand Down
3 changes: 0 additions & 3 deletions test/PolyhedralGeometry/polyhedron.jl
Original file line number Diff line number Diff line change
Expand Up @@ -585,12 +585,9 @@ end
@testset "Johnson solids" begin

for i in keys(Oscar._johnson_names)

j = johnson_solid(i)

@test j isa Polyhedron{<:EmbeddedNumFieldElem}
@test Polymake.polytope.isomorphic(Oscar.pm_object(j), Polymake.polytope.johnson_solid(i))

end

end

0 comments on commit 6933db9

Please sign in to comment.