Skip to content

Commit

Permalink
silly typos
Browse files Browse the repository at this point in the history
  • Loading branch information
danteluber committed Jul 16, 2024
1 parent 081844e commit 7b7e956
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/TropicalGeometry/matrix.jl
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ true
"""
function is_tropically_generic(A::MatrixElem{<:TropicalSemiringElem}, minOrMax)
@req convention(A) == minOrMax "Semiring convention not as declared"
function helper(C,B)
function helper(A,C,B)
for b in subsets(C,B)
Polymake.tropical.tsgn(A[b,:]) == 0 && return false
end
Expand All @@ -70,8 +70,8 @@ function is_tropically_generic(A::MatrixElem{<:TropicalSemiringElem}, minOrMax)
if nca == nra
return Polymake.tropical.tsgn(A) != 0
elseif nca>nra
return helper(nca,nra)
return helper(A,nra,nca)
else
return helper(nra,nca)
return helper(transpose(A),nca,nra)
end
end
2 changes: 1 addition & 1 deletion test/TropicalGeometry/matrix.jl
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ end
@test is_tropically_generic(A,min) == true
A = matrix(tropical_semiring(max),[1 0;0 1])
@test_throws ArgumentError is_tropically_generic(A,min)
A = tropical_matrix(tropical_semiring(max),[1 5;0 0;0 0])
A = matrix(tropical_semiring(max),[1 5;0 0;0 0])
@test is_tropically_generic(A,max) == false
@test is_tropically_generic(transpose(A),max) == false
end

0 comments on commit 7b7e956

Please sign in to comment.